From: Hangbin Liu <liuhangbin@gmail.com>
To: thinker.li@gmail.com
Cc: netdev@vger.kernel.org, ast@kernel.org, martin.lau@linux.dev,
kernel-team@meta.com, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
sinquersw@gmail.com, kuifeng@meta.com
Subject: Re: [PATCH net-next v3 3/5] net/ipv6: Remove expired routes with a separated list of routes.
Date: Sun, 4 Feb 2024 18:29:38 +0800 [thread overview]
Message-ID: <Zb9nEkehw-j8s7o6@Laptop-X1> (raw)
In-Reply-To: <20240202082200.227031-4-thinker.li@gmail.com>
On Fri, Feb 02, 2024 at 12:21:58AM -0800, thinker.li@gmail.com wrote:
> From: Kui-Feng Lee <thinker.li@gmail.com>
>
> FIB6 GC walks trees of fib6_tables to remove expired routes. Walking a tree
> can be expensive if the number of routes in a table is big, even if most of
> them are permanent. Checking routes in a separated list of routes having
> expiration will avoid this potential issue.
>
> Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
FYI, I will wait for David Ahern to help review this patch.
Thanks
Hangbin
next prev parent reply other threads:[~2024-02-04 10:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 8:21 [PATCH net-next v3 0/5] Remove expired routes with a separated list of routes thinker.li
2024-02-02 8:21 ` [PATCH net-next v3 1/5] net/ipv6: set expires in rt6_add_dflt_router() thinker.li
2024-02-02 11:52 ` Hangbin Liu
2024-02-05 4:42 ` David Ahern
2024-02-02 8:21 ` [PATCH net-next v3 2/5] net/ipv6: Remove unnecessary clean thinker.li
2024-02-05 4:42 ` David Ahern
2024-02-02 8:21 ` [PATCH net-next v3 3/5] net/ipv6: Remove expired routes with a separated list of routes thinker.li
2024-02-04 10:29 ` Hangbin Liu [this message]
2024-02-04 16:10 ` David Ahern
2024-02-05 4:45 ` David Ahern
2024-02-05 15:24 ` David Ahern
2024-02-02 8:21 ` [PATCH net-next v3 4/5] net/ipv6: set expires in modify_prefix_route() if RTF_EXPIRES is set thinker.li
2024-02-02 12:16 ` Hangbin Liu
2024-02-02 17:57 ` Kui-Feng Lee
2024-02-04 10:17 ` Hangbin Liu
2024-02-05 18:59 ` Kui-Feng Lee
2024-02-02 8:22 ` [PATCH net-next v3 5/5] selftests/net: Adding test cases of replacing routes and route advertisements thinker.li
2024-02-02 12:37 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zb9nEkehw-j8s7o6@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuifeng@meta.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sinquersw@gmail.com \
--cc=thinker.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox