From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Yanteng Si <siyanteng@loongson.cn>,
andrew@lunn.ch, hkallweit1@gmail.com, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
Jose.Abreu@synopsys.com, chenhuacai@loongson.cn,
guyinggang@loongson.cn, netdev@vger.kernel.org,
chris.chenfeiyang@gmail.com
Subject: Re: [PATCH net-next v7 7/9] net: stmmac: dwmac-loongson: Add GNET support
Date: Thu, 25 Jan 2024 18:41:08 +0000 [thread overview]
Message-ID: <ZbKrRL9W5D1kGn0F@shell.armlinux.org.uk> (raw)
In-Reply-To: <72hx6yfvbxiuvkunzu2tvn6glum5rjrzqaxsswml2fe6j3537w@ahtfn7q64ffe>
On Thu, Jan 25, 2024 at 09:38:30PM +0300, Serge Semin wrote:
> On Thu, Jan 25, 2024 at 04:36:39PM +0800, Yanteng Si wrote:
> > drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c: In function
> > 'loongson_gnet_data':
> > drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c:463:41: warning:
> > conversion from
> >
> > 'long unsigned int' to 'unsigned int' changes value from
> > '18446744073709551611' to '4294967291' [-Woverflow]
> > 463 | plat->mdio_bus_data->phy_mask = ~BIT(2);
> > | ^
> >
> > Unfortunately, we don't have an unsigned int macro for BIT(nr).
>
> Then the alternative ~(1 << 2) would be still more readable then the
> open-coded literal like 0xfffffffb. What would be even better than
> that:
>
> #define LOONGSON_GNET_PHY_ADDR 0x2
> ...
> plat->mdio_bus_data->phy_mask = ~(1 << LOONGSON_GNET_PHY_ADDR);
plat->mdio_bus_data->phy_mask = ~(u32)BIT(2);
would also work.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-01-25 18:41 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 14:17 [PATCH net-next v7 0/9] stmmac: Add Loongson platform support Yanteng Si
2023-12-19 14:17 ` [PATCH net-next v7 1/9] net: stmmac: Pass stmmac_priv and chan in some callbacks Yanteng Si
2023-12-20 15:08 ` Simon Horman
2023-12-21 9:40 ` Yanteng Si
2023-12-20 18:18 ` Serge Semin
2023-12-21 11:50 ` Yanteng Si
2023-12-21 12:53 ` Serge Semin
2023-12-21 13:21 ` Yanteng Si
2023-12-19 14:17 ` [PATCH net-next v7 2/9] net: stmmac: dwmac-loongson: Refactor code for loongson_dwmac_probe() Yanteng Si
2024-01-02 10:37 ` Russell King (Oracle)
2024-01-18 12:53 ` Yanteng Si
2023-12-19 14:17 ` [PATCH net-next v7 3/9] net: stmmac: dwmac-loongson: Add full PCI support Yanteng Si
2024-01-02 10:40 ` Russell King (Oracle)
2024-01-12 9:42 ` Yanteng Si
2024-01-18 12:56 ` Yanteng Si
2023-12-19 14:17 ` [PATCH net-next v7 4/9] net: stmmac: Add multi-channel supports Yanteng Si
2023-12-20 22:36 ` Serge Semin
2023-12-29 10:33 ` Yanteng Si
2023-12-30 11:25 ` Serge Semin
2024-01-01 6:57 ` Yanteng Si
2024-01-02 1:04 ` Serge Semin
2023-12-19 14:26 ` [PATCH net-next v7 5/9] net: stmmac: Add Loongson-specific register definitions Yanteng Si
2023-12-21 2:14 ` Serge Semin
2024-01-01 8:31 ` Yanteng Si
2024-01-01 12:26 ` Serge Semin
2024-01-12 10:08 ` Yanteng Si
2024-01-23 13:08 ` Yanteng Si
2024-01-24 13:59 ` Serge Semin
2023-12-19 14:26 ` [PATCH net-next v7 6/9] net: stmmac: dwmac-loongson: Add MSI support Yanteng Si
2023-12-19 14:26 ` [PATCH net-next v7 7/9] net: stmmac: dwmac-loongson: Add GNET support Yanteng Si
2023-12-21 2:34 ` Serge Semin
2024-01-01 7:27 ` Yanteng Si
2024-01-02 1:22 ` Serge Semin
2024-01-25 6:57 ` Yanteng Si
2024-01-29 11:45 ` Yanteng Si
2024-01-24 9:21 ` Yanteng Si
2024-01-24 13:51 ` Serge Semin
2024-01-25 8:36 ` Yanteng Si
2024-01-25 18:38 ` Serge Semin
2024-01-25 18:41 ` Russell King (Oracle) [this message]
2024-01-25 20:12 ` Serge Semin
2024-01-29 11:18 ` Yanteng Si
2023-12-19 14:28 ` [PATCH net-next v7 8/9] net: stmmac: dwmac-loongson: Disable flow control for GMAC Yanteng Si
2023-12-21 2:35 ` Serge Semin
2024-01-24 10:54 ` Yanteng Si
2023-12-19 14:28 ` [PATCH net-next v7 9/9] net: stmmac: Disable coe for some Loongson GNET Yanteng Si
2023-12-21 2:36 ` Serge Semin
2024-01-23 12:47 ` Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbKrRL9W5D1kGn0F@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=guyinggang@loongson.cn \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).