* [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE instead of kmem_cache_create
@ 2024-01-24 6:31 Kunwu Chan
2024-01-26 9:11 ` Steffen Klassert
2024-01-27 10:07 ` [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE() instead of kmem_cache_create() Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: Kunwu Chan @ 2024-01-24 6:31 UTC (permalink / raw)
To: steffen.klassert, herbert, davem, dsahern, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, Kunwu Chan
Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
net/ipv6/xfrm6_tunnel.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c
index 1323f2f6928e..0f3df26878a3 100644
--- a/net/ipv6/xfrm6_tunnel.c
+++ b/net/ipv6/xfrm6_tunnel.c
@@ -355,10 +355,7 @@ static int __init xfrm6_tunnel_init(void)
{
int rv;
- xfrm6_tunnel_spi_kmem = kmem_cache_create("xfrm6_tunnel_spi",
- sizeof(struct xfrm6_tunnel_spi),
- 0, SLAB_HWCACHE_ALIGN,
- NULL);
+ xfrm6_tunnel_spi_kmem = KMEM_CACHE(xfrm6_tunnel_spi, SLAB_HWCACHE_ALIGN);
if (!xfrm6_tunnel_spi_kmem)
return -ENOMEM;
rv = register_pernet_subsys(&xfrm6_tunnel_net_ops);
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE instead of kmem_cache_create
2024-01-24 6:31 [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
@ 2024-01-26 9:11 ` Steffen Klassert
2024-01-27 10:07 ` [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE() instead of kmem_cache_create() Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Steffen Klassert @ 2024-01-26 9:11 UTC (permalink / raw)
To: Kunwu Chan
Cc: herbert, davem, dsahern, edumazet, kuba, pabeni, netdev,
linux-kernel
On Wed, Jan 24, 2024 at 02:31:50PM +0800, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Applied, thanks a lot!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE() instead of kmem_cache_create()
2024-01-24 6:31 [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
2024-01-26 9:11 ` Steffen Klassert
@ 2024-01-27 10:07 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-01-27 10:07 UTC (permalink / raw)
To: Kunwu Chan, netdev, kernel-janitors, David Ahern, David S. Miller,
Eric Dumazet, Herbert Xu, Jakub Kicinski, Paolo Abeni,
Steffen Klassert
Cc: LKML
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
I suggest to replace the word “new” by a reference to the commit 8eb8284b412906181357c2b0110d879d5af95e52
("usercopy: Prepare for usercopy whitelisting").
See also related background information from 2017-06-10.
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-27 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24 6:31 [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
2024-01-26 9:11 ` Steffen Klassert
2024-01-27 10:07 ` [PATCH ipsec-next] xfrm6_tunnel: Use KMEM_CACHE() instead of kmem_cache_create() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).