Re: [PATCH net-next 3/4] selftests: bonding: reduce garp_test/arp_validate test time

Hangbin Liu
2024-01-26T12:53:05Z

On Fri, Jan 26, 2024 at 10:57:31AM +0100, Paolo Abeni wrote:
> On Wed, 2024-01-24 at 17:58 +0800, Hangbin Liu wrote:
> > @@ -276,10 +285,13 @@ garp_test()
> > active_slave=$(cmd_jq "ip -n ${s_ns} -d -j link show bond0" ".[].linkinfo.info_data.active_slave")
> > ip -n ${s_ns} link set ${active_slave} down
> >
> > - exp_num=$(echo "${param}" | cut -f6 -d ' ')
> > - sleep $((exp_num + 2))
> > + # wait for active link change
> > + sleep 1
>
> If 'slowwait' would loop around a sub-second sleep, I guess you could
> use 'slowwait' here, too.

OK, let me change the slowwait to sleep 0.1s.

>
> >
> > + exp_num=$(echo "${param}" | cut -f6 -d ' ')
> > active_slave=$(cmd_jq "ip -n ${s_ns} -d -j link show bond0" ".[].linkinfo.info_data.active_slave")
> > + slowwait_for_counter $((exp_num + 5)) $exp_num \
> > + tc_rule_handle_stats_get "dev s${active_slave#eth} ingress" 101 ".packets" "-n ${g_ns}"
> >
> > # check result
> > real_num=$(tc_rule_handle_stats_get "dev s${active_slave#eth} ingress" 101 ".packets" "-n ${g_ns}")
> > @@ -296,8 +308,8 @@ garp_test()
> > num_grat_arp()
> > {
> > local val
> > - for val in 10 20 30 50; do
> > - garp_test "mode active-backup miimon 100 num_grat_arp $val peer_notify_delay 1000"
> > + for val in 10 20 30; do
> > + garp_test "mode active-backup miimon 50 num_grat_arp $val peer_notify_delay 500"
>
> Can we reduce 'peer_notify_delay' even further, say to '250' and
> preserve the test effectiveness?

Hmm, maybe we can set miimon to 10. Then we can reduce peer_notify_delay to 100.

Jay, do you think if there is any side efect to set miimon to 10?

Thanks
Hangbin