netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: sfp: add quirk for ODI DFP-34X-2C2 GPON ONU SFP
@ 2024-01-28 14:23 Sergio Palumbo
  2024-01-28 14:43 ` Russell King (Oracle)
  0 siblings, 1 reply; 4+ messages in thread
From: Sergio Palumbo @ 2024-01-28 14:23 UTC (permalink / raw)
  To: Russell King, Andrew Lunn, Heiner Kallweit, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: netdev, linux-kernel

     DFP-34X-2C2 is a GPON spf module working at both 1000baseX
     and 2500baseX.
     Setting the module to LAN_SDS_MODE=6 the module is working
     at 2500baseX with auto negotiation see at
     https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/
     Unfortunatly the module's PHY is accessible at 1000baseX only.
     ethtool returning:
     Supported ports: [ Fibre ]
     Supported link modes: 1000baseX/Full

     After applying the quirk:
     Supported ports: [ Fibre ]
     Supported link modes: 1000baseX/Full
                           2500baseX/Full
     Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137
     Tested on sfp to ethernet Media Converter.
     Autonegotiating 1000baseX or 2500baseX according to the
     connected host speed.

     This module is existing in 2 versions:
     Vendor = "ODI"
     Vendor = "OEM"
     This is the patch for vendor "ODI"

     Patch has been inserted keeping the list in alphabetical order
     first by vendor first and then by part string.

Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it>
---
 drivers/net/phy/sfp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 3c0028a4af92..410375bc6b94 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = {
 	// 2500MBd NRZ in their EEPROM
 	SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex),
 
+	// ODI DFP-34X-2C2 GPON ONU support 2500base-X
+	SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex),
+
 	SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant),
 
 	// Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: sfp: add quirk for ODI DFP-34X-2C2 GPON ONU SFP
  2024-01-28 14:23 [PATCH net-next] net: sfp: add quirk for ODI DFP-34X-2C2 GPON ONU SFP Sergio Palumbo
@ 2024-01-28 14:43 ` Russell King (Oracle)
  2024-02-02 17:44   ` Sergio Palumbo
  0 siblings, 1 reply; 4+ messages in thread
From: Russell King (Oracle) @ 2024-01-28 14:43 UTC (permalink / raw)
  To: Sergio Palumbo
  Cc: Andrew Lunn, Heiner Kallweit, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, netdev, linux-kernel

Oh, a second repost. What's different from the first repost?

On Sun, Jan 28, 2024 at 03:23:06PM +0100, Sergio Palumbo wrote:
>      DFP-34X-2C2 is a GPON spf module working at both 1000baseX
>      and 2500baseX.
>      Setting the module to LAN_SDS_MODE=6 the module is working
>      at 2500baseX with auto negotiation see at
>      https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/
>      Unfortunatly the module's PHY is accessible at 1000baseX only.
>      ethtool returning:
>      Supported ports: [ Fibre ]
>      Supported link modes: 1000baseX/Full
> 
>      After applying the quirk:
>      Supported ports: [ Fibre ]
>      Supported link modes: 1000baseX/Full
>                            2500baseX/Full
>      Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137
>      Tested on sfp to ethernet Media Converter.
>      Autonegotiating 1000baseX or 2500baseX according to the
>      connected host speed.
> 
>      This module is existing in 2 versions:
>      Vendor = "ODI"
>      Vendor = "OEM"
>      This is the patch for vendor "ODI"
> 
>      Patch has been inserted keeping the list in alphabetical order
>      first by vendor first and then by part string.
> 
> Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it>
> ---
>  drivers/net/phy/sfp.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index 3c0028a4af92..410375bc6b94 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = {
>  	// 2500MBd NRZ in their EEPROM
>  	SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex),
>  
> +	// ODI DFP-34X-2C2 GPON ONU support 2500base-X
> +	SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex),
> +
>  	SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant),
>  
>  	// Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the
> -- 
> 2.34.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: sfp: add quirk for ODI DFP-34X-2C2 GPON ONU SFP
  2024-01-28 14:43 ` Russell King (Oracle)
@ 2024-02-02 17:44   ` Sergio Palumbo
  2024-02-02 18:03     ` Russell King (Oracle)
  0 siblings, 1 reply; 4+ messages in thread
From: Sergio Palumbo @ 2024-02-02 17:44 UTC (permalink / raw)
  To: Russell King (Oracle)
  Cc: Andrew Lunn, Heiner Kallweit, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, netdev, linux-kernel

Hello Russell,
this is the pach for the vendor "ODI".
Same hardware but different vendor.
I explained it in the description.
Hope this clarifies.

Thanks and regards

Sergio Palumbo

Il 28/01/2024 15:43, Russell King (Oracle) ha scritto:
> Oh, a second repost. What's different from the first repost?
>
> On Sun, Jan 28, 2024 at 03:23:06PM +0100, Sergio Palumbo wrote:
>>       DFP-34X-2C2 is a GPON spf module working at both 1000baseX
>>       and 2500baseX.
>>       Setting the module to LAN_SDS_MODE=6 the module is working
>>       at 2500baseX with auto negotiation see at
>>       https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/
>>       Unfortunatly the module's PHY is accessible at 1000baseX only.
>>       ethtool returning:
>>       Supported ports: [ Fibre ]
>>       Supported link modes: 1000baseX/Full
>>
>>       After applying the quirk:
>>       Supported ports: [ Fibre ]
>>       Supported link modes: 1000baseX/Full
>>                             2500baseX/Full
>>       Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137
>>       Tested on sfp to ethernet Media Converter.
>>       Autonegotiating 1000baseX or 2500baseX according to the
>>       connected host speed.
>>
>>       This module is existing in 2 versions:
>>       Vendor = "ODI"
>>       Vendor = "OEM"
>>       This is the patch for vendor "ODI"
>>
>>       Patch has been inserted keeping the list in alphabetical order
>>       first by vendor first and then by part string.
>>
>> Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it>
>> ---
>>   drivers/net/phy/sfp.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
>> index 3c0028a4af92..410375bc6b94 100644
>> --- a/drivers/net/phy/sfp.c
>> +++ b/drivers/net/phy/sfp.c
>> @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = {
>>   	// 2500MBd NRZ in their EEPROM
>>   	SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex),
>>   
>> +	// ODI DFP-34X-2C2 GPON ONU support 2500base-X
>> +	SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex),
>> +
>>   	SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant),
>>   
>>   	// Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the
>> -- 
>> 2.34.1
>>
>>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: sfp: add quirk for ODI DFP-34X-2C2 GPON ONU SFP
  2024-02-02 17:44   ` Sergio Palumbo
@ 2024-02-02 18:03     ` Russell King (Oracle)
  0 siblings, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2024-02-02 18:03 UTC (permalink / raw)
  To: Sergio Palumbo
  Cc: Andrew Lunn, Heiner Kallweit, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, netdev, linux-kernel

All the concerns with the OEM version of this patch apply to this one
as well.

On Fri, Feb 02, 2024 at 06:44:32PM +0100, Sergio Palumbo wrote:
> Hello Russell,
> this is the pach for the vendor "ODI".
> Same hardware but different vendor.
> I explained it in the description.
> Hope this clarifies.
> 
> Thanks and regards
> 
> Sergio Palumbo
> 
> Il 28/01/2024 15:43, Russell King (Oracle) ha scritto:
> > Oh, a second repost. What's different from the first repost?
> > 
> > On Sun, Jan 28, 2024 at 03:23:06PM +0100, Sergio Palumbo wrote:
> > >       DFP-34X-2C2 is a GPON spf module working at both 1000baseX
> > >       and 2500baseX.
> > >       Setting the module to LAN_SDS_MODE=6 the module is working
> > >       at 2500baseX with auto negotiation see at
> > >       https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/
> > >       Unfortunatly the module's PHY is accessible at 1000baseX only.
> > >       ethtool returning:
> > >       Supported ports: [ Fibre ]
> > >       Supported link modes: 1000baseX/Full
> > > 
> > >       After applying the quirk:
> > >       Supported ports: [ Fibre ]
> > >       Supported link modes: 1000baseX/Full
> > >                             2500baseX/Full
> > >       Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137
> > >       Tested on sfp to ethernet Media Converter.
> > >       Autonegotiating 1000baseX or 2500baseX according to the
> > >       connected host speed.
> > > 
> > >       This module is existing in 2 versions:
> > >       Vendor = "ODI"
> > >       Vendor = "OEM"
> > >       This is the patch for vendor "ODI"
> > > 
> > >       Patch has been inserted keeping the list in alphabetical order
> > >       first by vendor first and then by part string.
> > > 
> > > Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it>
> > > ---
> > >   drivers/net/phy/sfp.c | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> > > index 3c0028a4af92..410375bc6b94 100644
> > > --- a/drivers/net/phy/sfp.c
> > > +++ b/drivers/net/phy/sfp.c
> > > @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = {
> > >   	// 2500MBd NRZ in their EEPROM
> > >   	SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex),
> > > +	// ODI DFP-34X-2C2 GPON ONU support 2500base-X
> > > +	SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex),
> > > +
> > >   	SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant),
> > >   	// Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the
> > > -- 
> > > 2.34.1
> > > 
> > > 
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-02 18:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-28 14:23 [PATCH net-next] net: sfp: add quirk for ODI DFP-34X-2C2 GPON ONU SFP Sergio Palumbo
2024-01-28 14:43 ` Russell King (Oracle)
2024-02-02 17:44   ` Sergio Palumbo
2024-02-02 18:03     ` Russell King (Oracle)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).