Netdev List
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, daniel@iogearbox.net, lucien.xin@gmail.com,
	johannes.berg@intel.com
Subject: Re: [PATCH net-next] net: free altname using an RCU callback
Date: Mon, 29 Jan 2024 12:15:10 +0100	[thread overview]
Message-ID: <ZbeIvuPJi6K5aUF0@nanopsycho> (raw)
In-Reply-To: <20240126201449.2904078-1-kuba@kernel.org>

Fri, Jan 26, 2024 at 09:14:49PM CET, kuba@kernel.org wrote:
>We had to add another synchronize_rcu() in recent fix.
>Bite the bullet and add an rcu_head to netdev_name_node,
>free from RCU.
>
>Note that name_node does not hold any reference on dev
>to which it points, but there must be a synchronize_rcu()
>on device removal path, so we should be fine.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Looks good to me.

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

  reply	other threads:[~2024-01-29 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 20:14 [PATCH net-next] net: free altname using an RCU callback Jakub Kicinski
2024-01-29 11:15 ` Jiri Pirko [this message]
2024-01-29 12:36 ` Eric Dumazet
2024-01-29 14:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbeIvuPJi6K5aUF0@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes.berg@intel.com \
    --cc=kuba@kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox