From: Jiri Pirko <jiri@resnulli.us>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: forwarding: Add missing config entries
Date: Tue, 30 Jan 2024 15:30:46 +0100 [thread overview]
Message-ID: <ZbkIFrruZO5DXODm@nanopsycho> (raw)
In-Reply-To: <025abded7ff9cea5874a7fe35dcd3fd41bf5e6ac.1706286755.git.petrm@nvidia.com>
Fri, Jan 26, 2024 at 05:36:16PM CET, petrm@nvidia.com wrote:
>The config file contains a partial kernel configuration to be used by
>`virtme-configkernel --custom'. The presumption is that the config file
>contains all Kconfig options needed by the selftests from the directory.
>
>In net/forwarding/config, many are missing, which manifests as spurious
>failures when running the selftests, with messages about unknown device
>types, qdisc kinds or classifier actions. Add the missing configurations.
>
>Tested the resulting configuration using virtme-ng as follows:
>
> # vng -b -f tools/testing/selftests/net/forwarding/config
> # vng --user root
> (within the VM:)
> # make -C tools/testing/selftests TARGETS=net/forwarding run_tests
For me, all tests end up with:
SKIP: Cannot create interface. Name not specified
Do I miss some config file? If yes, can't we have some default testing
ifnames in case the config is not there?
next prev parent reply other threads:[~2024-01-30 14:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 16:36 [PATCH net-next] selftests: forwarding: Add missing config entries Petr Machata
2024-01-26 19:25 ` Jakub Kicinski
2024-01-29 10:45 ` Petr Machata
2024-01-30 2:31 ` Jakub Kicinski
2024-01-30 12:45 ` Paolo Abeni
2024-01-30 13:00 ` patchwork-bot+netdevbpf
2024-01-30 14:30 ` Jiri Pirko [this message]
2024-01-30 18:14 ` Jakub Kicinski
2024-02-13 17:17 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbkIFrruZO5DXODm@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).