* Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create
2024-01-30 9:25 [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
@ 2024-01-30 9:29 ` Nikolay Aleksandrov
2024-01-30 10:06 ` Jiri Pirko
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Nikolay Aleksandrov @ 2024-01-30 9:29 UTC (permalink / raw)
To: Kunwu Chan, roopa, davem, edumazet, kuba, pabeni
Cc: bridge, netdev, linux-kernel
On 30/01/2024 11:25, Kunwu Chan wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
> net/bridge/br_fdb.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index c622de5eccd0..c77591e63841 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -35,10 +35,7 @@ static struct kmem_cache *br_fdb_cache __read_mostly;
>
> int __init br_fdb_init(void)
> {
> - br_fdb_cache = kmem_cache_create("bridge_fdb_cache",
> - sizeof(struct net_bridge_fdb_entry),
> - 0,
> - SLAB_HWCACHE_ALIGN, NULL);
> + br_fdb_cache = KMEM_CACHE(net_bridge_fdb_entry, SLAB_HWCACHE_ALIGN);
> if (!br_fdb_cache)
> return -ENOMEM;
>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create
2024-01-30 9:25 [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
2024-01-30 9:29 ` Nikolay Aleksandrov
@ 2024-01-30 10:06 ` Jiri Pirko
2024-01-31 8:08 ` Kunwu Chan
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2024-01-30 10:06 UTC (permalink / raw)
To: Kunwu Chan
Cc: roopa, razor, davem, edumazet, kuba, pabeni, bridge, netdev,
linux-kernel
Tue, Jan 30, 2024 at 10:25:36AM CET, chentao@kylinos.cn wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>---
> net/bridge/br_fdb.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
>index c622de5eccd0..c77591e63841 100644
>--- a/net/bridge/br_fdb.c
>+++ b/net/bridge/br_fdb.c
>@@ -35,10 +35,7 @@ static struct kmem_cache *br_fdb_cache __read_mostly;
>
> int __init br_fdb_init(void)
> {
>- br_fdb_cache = kmem_cache_create("bridge_fdb_cache",
>- sizeof(struct net_bridge_fdb_entry),
>- 0,
>- SLAB_HWCACHE_ALIGN, NULL);
>+ br_fdb_cache = KMEM_CACHE(net_bridge_fdb_entry, SLAB_HWCACHE_ALIGN);
Same remark as to the previous patch, the name would change.
> if (!br_fdb_cache)
> return -ENOMEM;
>
>--
>2.39.2
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create
2024-01-30 9:25 [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
2024-01-30 9:29 ` Nikolay Aleksandrov
2024-01-30 10:06 ` Jiri Pirko
@ 2024-01-31 8:08 ` Kunwu Chan
2024-01-31 9:27 ` Jiri Pirko
2024-02-01 0:50 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 6+ messages in thread
From: Kunwu Chan @ 2024-01-31 8:08 UTC (permalink / raw)
To: jiri
Cc: bridge, netdev, linux-kernel, roopa, razor, davem, edumazet, kuba,
pabeni
Thanks again for your atttention.
The same reason as
https://lore.kernel.org/all/202e349f-a45a-46cb-ab8e-ff44c12b3628@kylinos.cn/
--
Thanks,
Kunwu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create
2024-01-30 9:25 [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
` (2 preceding siblings ...)
2024-01-31 8:08 ` Kunwu Chan
@ 2024-01-31 9:27 ` Jiri Pirko
2024-02-01 0:50 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2024-01-31 9:27 UTC (permalink / raw)
To: Kunwu Chan
Cc: roopa, razor, davem, edumazet, kuba, pabeni, bridge, netdev,
linux-kernel
Tue, Jan 30, 2024 at 10:25:36AM CET, chentao@kylinos.cn wrote:
>commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
>introduces a new macro.
>Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
>to simplify the creation of SLAB caches.
>
>Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create
2024-01-30 9:25 [PATCH net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create Kunwu Chan
` (3 preceding siblings ...)
2024-01-31 9:27 ` Jiri Pirko
@ 2024-02-01 0:50 ` patchwork-bot+netdevbpf
4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-01 0:50 UTC (permalink / raw)
To: Kunwu Chan
Cc: roopa, razor, davem, edumazet, kuba, pabeni, bridge, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 30 Jan 2024 17:25:36 +0800 you wrote:
> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> introduces a new macro.
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>
> [...]
Here is the summary with links:
- [net-next] net: bridge: Use KMEM_CACHE instead of kmem_cache_create
https://git.kernel.org/netdev/net-next/c/2dc23b6f852b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread