From: Jiri Pirko <jiri@resnulli.us>
To: Louis Peens <louis.peens@corigine.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Fei Qin <fei.qin@corigine.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com
Subject: Re: [PATCH net-next 1/2] nfp: update devlink device info output
Date: Wed, 31 Jan 2024 10:31:51 +0100 [thread overview]
Message-ID: <ZboThy4CrJRAITED@nanopsycho> (raw)
In-Reply-To: <20240131085426.45374-2-louis.peens@corigine.com>
Wed, Jan 31, 2024 at 09:54:25AM CET, louis.peens@corigine.com wrote:
>From: Fei Qin <fei.qin@corigine.com>
>
>Newer NIC will introduce a new part number field, add it to devlink
>device info.
>
>Signed-off-by: Fei Qin <fei.qin@corigine.com>
>Signed-off-by: Louis Peens <louis.peens@corigine.com>
>---
> drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
>index 635d33c0d6d3..91563b705639 100644
>--- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
>+++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c
>@@ -160,6 +160,7 @@ static const struct nfp_devlink_versions_simple {
> { DEVLINK_INFO_VERSION_GENERIC_BOARD_REV, "assembly.revision", },
> { DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE, "assembly.vendor", },
> { "board.model", /* code name */ "assembly.model", },
>+ { "board.pn", "pn", },
This looks quite generic. Could you please introduce:
DEVLINK_INFO_VERSION_GENERIC_BOARD_MODEL
DEVLINK_INFO_VERSION_GENERIC_BOARD_PN
and use those while you are at it?
Thanks!
pw-bot: cr
next prev parent reply other threads:[~2024-01-31 9:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:54 [PATCH net-next 0/2] nfp: series of minor driver improvements Louis Peens
2024-01-31 8:54 ` [PATCH net-next 1/2] nfp: update devlink device info output Louis Peens
2024-01-31 9:31 ` Jiri Pirko [this message]
2024-01-31 9:40 ` Louis Peens
2024-02-02 4:29 ` Jakub Kicinski
2024-01-31 8:54 ` [PATCH net-next 2/2] nfp: customize the dim profiles Louis Peens
2024-01-31 9:39 ` Jiri Pirko
2024-01-31 11:25 ` Louis Peens
2024-02-01 2:16 ` Yinjun Zhang
2024-02-01 7:42 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZboThy4CrJRAITED@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=kuba@kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).