Re: [PATCH v4 ipsec-next 2/2] xfrm: fix source address in icmp error generation from IPsec gateway

Steffen Klassert
2023-12-22T07:23:09Z

On Thu, Dec 21, 2023 at 02:12:36PM +0100, Antony Antony wrote:
> ---
> net/ipv4/icmp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
> index e63a3bf99617..bec234637122 100644
> --- a/net/ipv4/icmp.c
> +++ b/net/ipv4/icmp.c
> @@ -555,7 +555,6 @@ static struct rtable *icmp_route_lookup(struct net *net,
> XFRM_LOOKUP_ICMP);
> if (!IS_ERR(rt2)) {
> dst_release(&rt->dst);
> - memcpy(fl4, &fl4_dec, sizeof(*fl4));
> rt = rt2;
> } else if (PTR_ERR(rt2) == -EPERM) {
> if (rt)

This is generic icmp code, so I want to see an Ack from one of
the netdev Maintainers before I merge this into the ipsec-next
tree. Alternatively, you can just split the patchset and route
this one to net or net-next.