Re: [PATCH v2 ipsec-next 2/2] xfrm: fix source address in icmp error generation from IPsec gateway

Steffen Klassert
2023-11-17T09:21:42Z

On Fri, Oct 27, 2023 at 10:16:52AM +0200, Antony Antony wrote:
>
> diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
> index e63a3bf99617..bec234637122 100644
> --- a/net/ipv4/icmp.c
> +++ b/net/ipv4/icmp.c
> @@ -555,7 +555,6 @@ static struct rtable *icmp_route_lookup(struct net *net,
> XFRM_LOOKUP_ICMP);
> if (!IS_ERR(rt2)) {
> dst_release(&rt->dst);
> - memcpy(fl4, &fl4_dec, sizeof(*fl4));

This is not really IPsec code. The change needs either an
Ack of one of the netdev Maintainers, or it has to go
through the nedev tree. Also, please consider this as
a fix.