Re: [PATCH ipsec-next 1/2] xfrm: introduce forwarding of ICMP Error messages

kernel test robot
2023-10-26T19:42:42Z

Hi Antony,

kernel test robot noticed the following build warnings:

[auto build test WARNING on klassert-ipsec-next/master]
[also build test WARNING on klassert-ipsec/master net-next/main net/main linus/master v6.6-rc7 next-20231026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Antony-Antony/xfrm-fix-source-address-in-icmp-error-generation-from-IPsec-gateway/20231026-234542
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
patch link: https://lore.kernel.org/r/4b30e07300159db93ec0f6b31778aa0f6a41ef21.1698331320.git.antony.antony%40secunet.com
patch subject: [PATCH ipsec-next 1/2] xfrm: introduce forwarding of ICMP Error messages
config: csky-randconfig-002-20231027 (https://download.01.org/0day-ci/archive/20231027/202310270353.sobcrQay-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270353.sobcrQay-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310270353.sobcrQay-lkp@intel.com/

All warnings (new ones prefixed by >>):

net/xfrm/xfrm_policy.c: In function 'icmp_err_packet':
>> net/xfrm/xfrm_policy.c:3490:30: warning: unused variable 'fl6' [-Wunused-variable]
3490 | const struct flowi6 *fl6 = &fl->u.ip6;
| ^~~

vim +/fl6 +3490 net/xfrm/xfrm_policy.c

3487
3488 static bool icmp_err_packet(const struct flowi *fl, unsigned short family)
3489 {
> 3490 const struct flowi6 *fl6 = &fl->u.ip6;
3491 const struct flowi4 *fl4 = &fl->u.ip4;
3492
3493 if (family == AF_INET &&
3494 fl4->flowi4_proto == IPPROTO_ICMP &&
3495 (fl4->fl4_icmp_type == ICMP_DEST_UNREACH ||
3496 fl4->fl4_icmp_type == ICMP_TIME_EXCEEDED))
3497 return true;
3498

--
0-DAY CI Kernel Test Service