From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCHv2 net-next 2/4] selftests: bonding: use tc filter to check if LACP was sent
Date: Thu, 1 Feb 2024 14:43:59 +0800 [thread overview]
Message-ID: <Zbs9r16e3FdhHIkH@Laptop-X1> (raw)
In-Reply-To: <20240201062954.421145-3-liuhangbin@gmail.com>
On Thu, Feb 01, 2024 at 02:29:52PM +0800, Hangbin Liu wrote:
> Use tc filter to check if LACP was sent, which is accurate and save
> more time.
>
> No need to remove bonding module as some test env may buildin bonding.
> And the bond link has been deleted.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> .../net/bonding/bond-break-lacpdu-tx.sh | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh b/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> index 6358df5752f9..01dcf501da41 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> @@ -20,21 +20,21 @@
> # +------+ +------+
> #
> # We use veths instead of physical interfaces
> +REQUIRE_MZ=no
> +NUM_NETIFS=0
> +lib_dir=$(dirname "$0")
> +source "$lib_dir"/net_forwarding_lib.sh
Opps, forgot to rebase to latest net-next, which merged Benjamin's lib update.
I will post new version tomorrow.
Thanks
Hangbin
next prev parent reply other threads:[~2024-02-01 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 6:29 [PATCHv2 net-next 0/4] selftests: bonding: use slowwait when waiting Hangbin Liu
2024-02-01 6:29 ` [PATCHv2 net-next 1/4] selftests/net/forwarding: add slowwait functions Hangbin Liu
2024-02-01 6:29 ` [PATCHv2 net-next 2/4] selftests: bonding: use tc filter to check if LACP was sent Hangbin Liu
2024-02-01 6:43 ` Hangbin Liu [this message]
2024-02-01 6:29 ` [PATCHv2 net-next 3/4] selftests: bonding: reduce garp_test/arp_validate test time Hangbin Liu
2024-02-01 6:29 ` [PATCHv2 net-next 4/4] selftests: bonding: use slowwait instead of hard code sleep Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbs9r16e3FdhHIkH@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox