Re: [PATCH 2/3] net/sched: netem: get rid of unnecesary version message

[Jiri Pirko <jiri@resnulli.us>]

Thu, Feb 01, 2024 at 04:45:59AM CET, stephen@networkplumber.org wrote:
>The version of netem module is irrelevant and was never useful.
>Remove it.
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
> net/sched/sch_netem.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
>index 7c37a69aba0e..f712d03ad854 100644
>--- a/net/sched/sch_netem.c
>+++ b/net/sched/sch_netem.c
>@@ -26,8 +26,6 @@
> #include <net/pkt_sched.h>
> #include <net/inet_ecn.h>
> 
>-#define VERSION "1.3"
>-
> /*	Network Emulation Queuing algorithm.
> 	====================================
> 
>@@ -1300,13 +1298,14 @@ static struct Qdisc_ops netem_qdisc_ops __read_mostly = {
> 
> static int __init netem_module_init(void)
> {
>-	pr_info("netem: version " VERSION "\n");
> 	return register_qdisc(&netem_qdisc_ops);
> }
>+
> static void __exit netem_module_exit(void)
> {
> 	unregister_qdisc(&netem_qdisc_ops);
> }
>+

These whitespace changes look unrelated to the patch. Anyway:

Reviewed-by: Jiri Pirko <jiri@nvidia.com>


> module_init(netem_module_init)
> module_exit(netem_module_exit)
> MODULE_LICENSE("GPL");
>-- 
>2.43.0
>
>