From: Jiri Pirko <jiri@resnulli.us>
To: Antoine Tenart <atenart@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] tunnels: fix out of bounds access when building IPv6 PMTU error
Date: Thu, 1 Feb 2024 13:45:13 +0100 [thread overview]
Message-ID: <ZbuSWVur9iOYXp2v@nanopsycho> (raw)
In-Reply-To: <20240201083817.12774-1-atenart@kernel.org>
Thu, Feb 01, 2024 at 09:38:15AM CET, atenart@kernel.org wrote:
>If the ICMPv6 error is built from a non-linear skb we get the following
>splat,
>
> BUG: KASAN: slab-out-of-bounds in do_csum+0x220/0x240
> Read of size 4 at addr ffff88811d402c80 by task netperf/820
> CPU: 0 PID: 820 Comm: netperf Not tainted 6.8.0-rc1+ #543
> ...
> kasan_report+0xd8/0x110
> do_csum+0x220/0x240
> csum_partial+0xc/0x20
> skb_tunnel_check_pmtu+0xeb9/0x3280
> vxlan_xmit_one+0x14c2/0x4080
> vxlan_xmit+0xf61/0x5c00
> dev_hard_start_xmit+0xfb/0x510
> __dev_queue_xmit+0x7cd/0x32a0
> br_dev_queue_push_xmit+0x39d/0x6a0
>
>Use skb_checksum instead of csum_partial who cannot deal with non-linear
>SKBs.
>
>Fixes: 4cb47a8644cc ("tunnels: PMTU discovery support for directly bridged IP packets")
>Signed-off-by: Antoine Tenart <atenart@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2024-02-01 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 8:38 [PATCH net] tunnels: fix out of bounds access when building IPv6 PMTU error Antoine Tenart
2024-02-01 12:45 ` Jiri Pirko [this message]
2024-02-03 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbuSWVur9iOYXp2v@nanopsycho \
--to=jiri@resnulli.us \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).