* [PATCH net v1] doc/netlink/specs: Add missing attr in rt_link spec
@ 2024-02-01 11:38 Donald Hunter
2024-02-01 12:50 ` Jiri Pirko
2024-02-01 17:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Donald Hunter @ 2024-02-01 11:38 UTC (permalink / raw)
To: netdev, Jakub Kicinski, David S. Miller, Eric Dumazet,
Paolo Abeni, Jacob Keller, Jiri Pirko, Vadim Fedorenko,
Arkadiusz Kubalewski
Cc: donald.hunter, Donald Hunter
IFLA_DPLL_PIN was added to rt_link messages but not to the spec, which
breaks ynl. Add the missing definitions to the rt_link ynl spec.
Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice")
Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
---
Documentation/netlink/specs/rt_link.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/netlink/specs/rt_link.yaml b/Documentation/netlink/specs/rt_link.yaml
index 1ad01d52a863..8e4d19adee8c 100644
--- a/Documentation/netlink/specs/rt_link.yaml
+++ b/Documentation/netlink/specs/rt_link.yaml
@@ -942,6 +942,10 @@ attribute-sets:
-
name: gro-ipv4-max-size
type: u32
+ -
+ name: dpll-pin
+ type: nest
+ nested-attributes: link-dpll-pin-attrs
-
name: af-spec-attrs
attributes:
@@ -1627,6 +1631,12 @@ attribute-sets:
-
name: used
type: u8
+ -
+ name: link-dpll-pin-attrs
+ attributes:
+ -
+ name: id
+ type: u32
sub-messages:
-
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v1] doc/netlink/specs: Add missing attr in rt_link spec
2024-02-01 11:38 [PATCH net v1] doc/netlink/specs: Add missing attr in rt_link spec Donald Hunter
@ 2024-02-01 12:50 ` Jiri Pirko
2024-02-01 17:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2024-02-01 12:50 UTC (permalink / raw)
To: Donald Hunter
Cc: netdev, Jakub Kicinski, David S. Miller, Eric Dumazet,
Paolo Abeni, Jacob Keller, Vadim Fedorenko, Arkadiusz Kubalewski,
donald.hunter
Thu, Feb 01, 2024 at 12:38:53PM CET, donald.hunter@gmail.com wrote:
>IFLA_DPLL_PIN was added to rt_link messages but not to the spec, which
>breaks ynl. Add the missing definitions to the rt_link ynl spec.
>
>Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice")
>Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
Ah, sorry about this. I wonder how could we avoid this in the future.
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net v1] doc/netlink/specs: Add missing attr in rt_link spec
2024-02-01 11:38 [PATCH net v1] doc/netlink/specs: Add missing attr in rt_link spec Donald Hunter
2024-02-01 12:50 ` Jiri Pirko
@ 2024-02-01 17:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-01 17:30 UTC (permalink / raw)
To: Donald Hunter
Cc: netdev, kuba, davem, edumazet, pabeni, jacob.e.keller, jiri,
vadim.fedorenko, arkadiusz.kubalewski, donald.hunter
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 1 Feb 2024 11:38:53 +0000 you wrote:
> IFLA_DPLL_PIN was added to rt_link messages but not to the spec, which
> breaks ynl. Add the missing definitions to the rt_link ynl spec.
>
> Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice")
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
> ---
> Documentation/netlink/specs/rt_link.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Here is the summary with links:
- [net,v1] doc/netlink/specs: Add missing attr in rt_link spec
https://git.kernel.org/netdev/net/c/069a6ed2992d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-01 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-01 11:38 [PATCH net v1] doc/netlink/specs: Add missing attr in rt_link spec Donald Hunter
2024-02-01 12:50 ` Jiri Pirko
2024-02-01 17:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).