From: Jiri Pirko <jiri@resnulli.us>
To: Jinjian Song <songjinjian@hotmail.com>
Cc: netdev@vger.kernel.org, chandrashekar.devegowda@intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com,
loic.poulain@linaro.org, ryazanov.s.a@gmail.com,
johannes@sipsolutions.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.com, vsankar@lenovo.com,
letitia.tsai@hp.com, pin-hao.huang@hp.com,
danielwinkler@google.com, nmarupaka@google.com,
joey.zhao@fibocom.com, liuqf@fibocom.com, felix.yan@fibocom.com,
angel.huang@fibocom.com, freddy.lin@fibocom.com,
alan.zhang1@fibocom.com, zhangrc@fibocom.com,
Jinjian Song <jinjian.song@fibocom.com>
Subject: Re: [net-next v7 4/4] net: wwan: t7xx: Add fastboot WWAN port
Date: Thu, 1 Feb 2024 17:12:28 +0100 [thread overview]
Message-ID: <ZbvC7E_J7U6zBwJD@nanopsycho> (raw)
In-Reply-To: <MEYP282MB269704BFB8AC4893C300EDBCBB432@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
Thu, Feb 01, 2024 at 04:13:40PM CET, songjinjian@hotmail.com wrote:
>From: Jinjian Song <jinjian.song@fibocom.com>
[...]
>+static void t7xx_port_wwan_create(struct t7xx_port *port)
>+{
>+ const struct t7xx_port_conf *port_conf = port->port_conf;
>+ unsigned int header_len = sizeof(struct ccci_header), mtu;
>+ struct wwan_port_caps caps;
>+
>+ if (!port->wwan.wwan_port) {
>+ mtu = t7xx_get_port_mtu(port);
>+ caps.frag_len = mtu - header_len;
>+ caps.headroom_len = header_len;
>+ port->wwan.wwan_port = wwan_create_port(port->dev, port_conf->port_type,
>+ &wwan_ops, &caps, port);
>+ if (IS_ERR(port->wwan.wwan_port))
>+ dev_err(port->dev, "Unable to create WWWAN port %s", port_conf->name);
To many "W"s.
>+ }
>+}
[...]
next prev parent reply other threads:[~2024-02-01 16:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240201151340.4963-1-songjinjian@hotmail.com>
2024-02-01 15:13 ` [net-next v7 1/4] wwan: core: Add WWAN fastboot port type Jinjian Song
2024-02-01 15:13 ` [net-next v7 2/4] net: wwan: t7xx: Add sysfs attribute for device state machine Jinjian Song
2024-02-01 16:11 ` Jiri Pirko
2024-02-02 2:16 ` Jinjian Song
2024-02-02 7:23 ` Jiri Pirko
2024-02-02 15:07 ` Jinjian Song
2024-02-01 15:13 ` [net-next v7 3/4] net: wwan: t7xx: Infrastructure for early port configuration Jinjian Song
2024-02-01 15:13 ` [net-next v7 4/4] net: wwan: t7xx: Add fastboot WWAN port Jinjian Song
2024-02-01 16:12 ` Jiri Pirko [this message]
2024-02-02 2:17 ` Jinjian Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbvC7E_J7U6zBwJD@nanopsycho \
--to=jiri@resnulli.us \
--cc=alan.zhang1@fibocom.com \
--cc=angel.huang@fibocom.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=danielwinkler@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=felix.yan@fibocom.com \
--cc=freddy.lin@fibocom.com \
--cc=haijun.liu@mediatek.com \
--cc=jinjian.song@fibocom.com \
--cc=joey.zhao@fibocom.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=letitia.tsai@hp.com \
--cc=linux-kernel@vger.kernel.com \
--cc=liuqf@fibocom.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=nmarupaka@google.com \
--cc=pabeni@redhat.com \
--cc=pin-hao.huang@hp.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=songjinjian@hotmail.com \
--cc=vsankar@lenovo.com \
--cc=zhangrc@fibocom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox