From: Jiri Pirko <jiri@resnulli.us>
To: Aahil Awatramani <aahila@google.com>
Cc: David Dillow <dave@thedillows.org>,
Mahesh Bandewar <maheshb@google.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Martin KaFai Lau <martin.lau@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6] bonding: Add independent control state machine
Date: Thu, 1 Feb 2024 17:21:38 +0100 [thread overview]
Message-ID: <ZbvFEtQskK3xzi6y@nanopsycho> (raw)
In-Reply-To: <20240129202741.3424902-1-aahila@google.com>
Mon, Jan 29, 2024 at 09:27:41PM CET, aahila@google.com wrote:
[...]
>diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c
>index 43be458422b3..95d88df94756 100644
>--- a/drivers/net/bonding/bond_procfs.c
>+++ b/drivers/net/bonding/bond_procfs.c
>@@ -154,6 +154,8 @@ static void bond_info_show_master(struct seq_file *seq)
> (bond->params.lacp_active) ? "on" : "off");
> seq_printf(seq, "LACP rate: %s\n",
> (bond->params.lacp_fast) ? "fast" : "slow");
>+ seq_printf(seq, "LACP coupled_control: %s\n",
>+ (bond->params.coupled_control) ? "on" : "off");
Hmm, I wonder how it makes sense to add new features here. This should
rot.
> seq_printf(seq, "Min links: %d\n", bond->params.min_links);
> optval = bond_opt_get_val(BOND_OPT_AD_SELECT,
> bond->params.ad_select);
[...]
next prev parent reply other threads:[~2024-02-01 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 20:27 [PATCH net-next v6] bonding: Add independent control state machine Aahil Awatramani
2024-02-01 10:15 ` Paolo Abeni
2024-02-01 14:43 ` Jay Vosburgh
2024-02-01 14:52 ` Paolo Abeni
2024-02-01 16:21 ` Jiri Pirko [this message]
2024-02-01 18:45 ` Aahil Awatramani
2024-02-02 7:17 ` Jiri Pirko
2024-02-02 17:59 ` Aahil Awatramani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbvFEtQskK3xzi6y@nanopsycho \
--to=jiri@resnulli.us \
--cc=aahila@google.com \
--cc=andy@greyhouse.net \
--cc=daniel@iogearbox.net \
--cc=dave@thedillows.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=maheshb@google.com \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).