Re: [PATCH net-next v6] bonding: Add independent control state machine

[Jiri Pirko <jiri@resnulli.us>]

Thu, Feb 01, 2024 at 07:45:23PM CET, aahila@google.com wrote:
>> Any chance we can have some coverage via self-tests?
>
>I plan to work on these self-tests decoupled from the current patch.
>
>> Hmm, I wonder how it makes sense to add new features here. This should
>> rot.
>
>Could you clarify what you are suggesting here?

Don't touch procfs here.

>
>
>On Thu, Feb 1, 2024 at 8:28 AM Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Mon, Jan 29, 2024 at 09:27:41PM CET, aahila@google.com wrote:
>>
>> [...]
>>
>>
>> >diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c
>> >index 43be458422b3..95d88df94756 100644
>> >--- a/drivers/net/bonding/bond_procfs.c
>> >+++ b/drivers/net/bonding/bond_procfs.c
>> >@@ -154,6 +154,8 @@ static void bond_info_show_master(struct seq_file *seq)
>> >                          (bond->params.lacp_active) ? "on" : "off");
>> >               seq_printf(seq, "LACP rate: %s\n",
>> >                          (bond->params.lacp_fast) ? "fast" : "slow");
>> >+              seq_printf(seq, "LACP coupled_control: %s\n",
>> >+                         (bond->params.coupled_control) ? "on" : "off");
>>
>> Hmm, I wonder how it makes sense to add new features here. This should
>> rot.
>>
>>
>> >               seq_printf(seq, "Min links: %d\n", bond->params.min_links);
>> >               optval = bond_opt_get_val(BOND_OPT_AD_SELECT,
>> >                                         bond->params.ad_select);
>>
>> [...]