From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ECE217C62 for ; Fri, 2 Feb 2024 07:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706858286; cv=none; b=FgpZwTutTxTA9i5GyA9Le2mDXok0dMDUB5/BNtN0nvz3N8+z+OOzxjSkP3ryf3zWBP6mJXlth9eOwmGIC7GxJt2JktqOeMYQcjZDAc8vuzZUkV2ukqSaEbj6EzkAYtXfx/gSBymhvgQRdexN7Xbs3s4I6KOMtYC06R4hlWzJH2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706858286; c=relaxed/simple; bh=nm4ZQS/VjFA0/33oXv/rZ2TvSf0VJ3+fW6AC5T+GWFY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=izjYFHjGDABiZhAU7XDaXwvhU2PgEIdLDdD7ts4/9pckkjLnCir93kLkDAIbeVUbHsKJUjOTpLH//j77LY+RLIuMeGMfKlcJJklpqZ+0j8p7DOY8s8hX2UgZWmIIAnM+AZlTv6eWmQHdem/pY9Jiq73+81MDQz0IAxjFGYCuJ+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=rmVTRZ+8; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="rmVTRZ+8" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-3394ca0c874so1242613f8f.2 for ; Thu, 01 Feb 2024 23:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1706858282; x=1707463082; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=aAUjuRqQR3EqFDoyAUglRvCh4JpyuuFKVUjgTVN2xyU=; b=rmVTRZ+8PCWvNWzs0+MdhQgerkdXtWbyRkWOV0mzLY5Z8xFf7B83aJd0Jk9bdt1Zlw D39tNrxTXQu3XD+OS+sipJIoD47PQhgBVaRuEuLTMYNXjP9hyRgYcZM2NxFs5w4rJs7T Wi4/ctnnkarBrN9eTbqTsg37b+IwNaH23n48kTRjvrP6h+xPQlWwaNOSoVsliq/xQD2Z 88L9wKkNxr+ijOmBbVb460xY8UtNNm0Il+91Mx+oaau1LwVGO9pzR3UrxFZbka5ZK7Op uTZkqjKZNlgPnny3oVUOtlzg7D+c1w2iljYUhp8goN828ucqInNK/k1QLPd0BSqrqVLv FiKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706858282; x=1707463082; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aAUjuRqQR3EqFDoyAUglRvCh4JpyuuFKVUjgTVN2xyU=; b=BUCXYGAF3Kk/lzslPjZBRvPiVgHs27BuBptNstGpj1d3pHmOacDhOVAK3g3dmfms1i c5X9vtfPACSGbvS9XKuO4jkPjLUGyu2XZxLD7qOdw77x6wvztgNldsNGiFDObE7BdxN0 6TB4bsF8MaryEbaePTguhE1Pc/5e/1sIBjKj6DHhc7dLpWWaT6Qq5/GbAQ7/iLXH9+Ay KkY0VaeTWnw5wVW3DTj36GBuqd2JXa2GoxCE3x/zkJfjzJ7miOdAa72ui//w+/B6T6lx b9BmMHzME4FASUP3zl0QMPVZK3Z/8S2e9m2bWTNu2I1t/nrS1Kp4e/TzUmnvUpakPg8G Jf2w== X-Gm-Message-State: AOJu0YxOB29LL+qtn3/2CTycf5HY1GraR8/NKzWxMP2GwKmfk3G9fehr jLvkWn1y6E3HrZCAPX+kf1Q9noWSFSdlcyVMs1lc/K9LGktBzHcrerbJhwRv0Ss= X-Google-Smtp-Source: AGHT+IG2x8GDdFF8OLIvYlGbLM6O8MjsOOzCIZrIporr34iTNIHJYlQ0U7dsMCWY0nH0mKqaxkdoow== X-Received: by 2002:a5d:62c6:0:b0:33a:febd:f1bb with SMTP id o6-20020a5d62c6000000b0033afebdf1bbmr659915wrv.33.1706858282218; Thu, 01 Feb 2024 23:18:02 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVX9Y+zLh8jP+uos0qelWWa7RYcG+vufyZ8JE1v5YdeSbhliA/oBkPpOd7x1g+fDkhcJgFYKoz9pi02ivCUjXoVOey32Sfu8zvAMQaE9bAmlMYKfUu2IatqZgj931a/6SRDOAdf90pbUvUDB/TaRzGcd1itGi8Pf0jsyAaFNdY55TN2F6wU0sBo6xf3lPhBypzoBnLU3F/6nIHLQs2BkWTOBCqkTuYcm7aH/Vcx5wGNR2wKkzbuPhdT/enpapPso90uQDqwYlq0ZekAvkd5uM8Ky7NfbMyxwlxH9AhpRhSYp4kBdCRhCtEiG9YAOyl7feFMxw6KfwoAQo84agcsNSVnxzfl7sw1QbEAa+nhpDnlBbrKAVWyEU9/IxiwBtk+FhBbnF218OzVJ5ff8liJSYGPF2J+ms2N2z6UjcL6OQya5iTYuKMkTLab0s9+tY1jhL8PTiyZ4ZnO6Bp+PJyEJ3jJQx8= Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id d22-20020adfa356000000b0033af51eafc6sm1244237wrb.104.2024.02.01.23.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 23:18:01 -0800 (PST) Date: Fri, 2 Feb 2024 08:17:58 +0100 From: Jiri Pirko To: Aahil Awatramani Cc: David Dillow , Mahesh Bandewar , Jay Vosburgh , Hangbin Liu , Andy Gospodarek , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Martin KaFai Lau , Herbert Xu , Daniel Borkmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v6] bonding: Add independent control state machine Message-ID: References: <20240129202741.3424902-1-aahila@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Thu, Feb 01, 2024 at 07:45:23PM CET, aahila@google.com wrote: >> Any chance we can have some coverage via self-tests? > >I plan to work on these self-tests decoupled from the current patch. > >> Hmm, I wonder how it makes sense to add new features here. This should >> rot. > >Could you clarify what you are suggesting here? Don't touch procfs here. > > >On Thu, Feb 1, 2024 at 8:28 AM Jiri Pirko wrote: >> >> Mon, Jan 29, 2024 at 09:27:41PM CET, aahila@google.com wrote: >> >> [...] >> >> >> >diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c >> >index 43be458422b3..95d88df94756 100644 >> >--- a/drivers/net/bonding/bond_procfs.c >> >+++ b/drivers/net/bonding/bond_procfs.c >> >@@ -154,6 +154,8 @@ static void bond_info_show_master(struct seq_file *seq) >> > (bond->params.lacp_active) ? "on" : "off"); >> > seq_printf(seq, "LACP rate: %s\n", >> > (bond->params.lacp_fast) ? "fast" : "slow"); >> >+ seq_printf(seq, "LACP coupled_control: %s\n", >> >+ (bond->params.coupled_control) ? "on" : "off"); >> >> Hmm, I wonder how it makes sense to add new features here. This should >> rot. >> >> >> > seq_printf(seq, "Min links: %d\n", bond->params.min_links); >> > optval = bond_opt_get_val(BOND_OPT_AD_SELECT, >> > bond->params.ad_select); >> >> [...]