From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C1C7C085 for ; Fri, 2 Feb 2024 10:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706869734; cv=none; b=V8RmD90jrkA8vvmxSFDWqHhNOieztl1LxRId9P37zgr4l74WYKVJDOk8iRNckVO9r4z44HmRfmMP7WfgXi/Gt4ej3ore2knKekb8GaZs99MAQSDmOFKAkbEeSqDFDvIU1nPEHPvsfx+CLM9bJlyjQeeCkyRjiJV8WhLgPBpxAWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706869734; c=relaxed/simple; bh=dL7uGPwyAybhRY8krEHZS8RFuBz71FSPqdxQAnbnt4g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BaC2IBMQB6M8bkcRSkomUGB78VMlTTnW3wIBxFIZ7tRQ3ysCzYGkKv5rBF3OunEiymaXFdb4Bl1IXk2ahmysHqj/9oJZQPo9AEumAg1xLTVott1DYgyyl2HVo3OIMzxP2bTb0gF88T5G8jWEBaFV2jjc1DK5NGTP0oX2RZVqs6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=YNK2lbY/; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="YNK2lbY/" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a370e7e1e02so46317666b.0 for ; Fri, 02 Feb 2024 02:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1706869731; x=1707474531; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=omQ7+GMjSKpytu49hD1r+ofiPUD7xzcIASpmQF4KMg8=; b=YNK2lbY/UaJmTekLCjyhzQA/VXUGKOuaCtwbNZY3sU6iGMIzDo5JLg5tOKxM25sTdf q4t56n6epQh7Y5SZE94UR6oWo3fYId+m+g3L9vaGN8ie6fTJTg0v0fcMRygrE4skG8Bv xxGoXxhbHKp+3jUO/ALwzcLmRzLUwgLj4VhUno5cWR/perXPJiWNj+5meOqsOfP5rZTQ H591aLcXGj6gR0YqDPakdICLuCS8Bk81ALUaAj7t0XT/IshEjZx8u8cnROm5kkdACchV pfXVlTk2oOwyDp6OmmUEBMT741R375/LWtDB6J+007rpxeoqNzj8KKiUZ9Eeu44Qrzpd O9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706869731; x=1707474531; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=omQ7+GMjSKpytu49hD1r+ofiPUD7xzcIASpmQF4KMg8=; b=q4Jgnixt7l/VsdQUR9Lgco15DB4ZSEfEOzy81F9Nnm6B6TgCoKKFdU0A4eKmXlWpnN f/45O2Kw/troVyHHmwT01hQSbtXSi8udk1A75qYmDppbiptkRZDrfoWybD30AMPzDHkp z7I7kcVhvfnQqGzEtGKXQQhWvPvhEzkBY2ITxraM8ft/YfAgPkTjK/PpR0x10kA7Zdfy vVngxqikLEzpsWLve5d4MPztn7q1G2roVSy54V4Oc3foez6ZA+X2QJSnzGlVIaSbCycC SexDLouR1RVo8sjpSoCdUD+nXAbnjYFx/786/4uMw8CLtj/q28FQy6S5zW8YA0leZQr6 R3/w== X-Gm-Message-State: AOJu0YyDzLeooofeo6MqyPkTfVOthrdH7i/d/vmv0FXJcVZZU8oXkApz 0yEiG5mrhlx6ZSUi+P6rneti30HRymQQ19VldEcFpkMaN0tPZaXWLcwmz4AL/nM= X-Google-Smtp-Source: AGHT+IG4AOnjxO6LKG0JUwNvEozHpt5V9r6qBfw97aEaTDBYIAlV4QevQFNkea1ghpdkAe0RVG5OQw== X-Received: by 2002:a17:906:dfcb:b0:a31:616c:7a7 with SMTP id jt11-20020a170906dfcb00b00a31616c07a7mr5920041ejc.16.1706869731229; Fri, 02 Feb 2024 02:28:51 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVWuzfSG63KyB0eGfg4z9LmgreyMrmTwJktNb4iEoYA/y6yAJz8gCvOYk6l56zD43KH4jbqDkNe6+8AgKtqnabalYpJQufAIq4DcIfgwOOEKrFg1EaqVX6xHFIeGJ4kJFE9KfUPM8PCTLWZv591nrUWGqcJsM5yh7E+9knsxJXAC2DQ5SAnaBWx661SjCsDXPs0njgF4IBFtRmrA1wzfSCv3kt4hE82dvLWnU6SvV8zKWI2IqirvTwsrtUFqdCanHBTpzb6g03uuDaRko42pYmXJW1cDtKiJo4CdhiNRMJAVQGszqTfxvJVMfraXCRa/yDSnHVHg4djeDJ8A4CN Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id pw22-20020a17090720b600b00a310c9d0cb9sm727641ejb.121.2024.02.02.02.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 02:28:50 -0800 (PST) Date: Fri, 2 Feb 2024 11:28:47 +0100 From: Jiri Pirko To: Kunwu Chan Cc: dhowells@redhat.com, marc.dionne@auristor.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] rxrpc: Simplify the allocation of slab caches Message-ID: References: <20240201100924.210298-1-chentao@kylinos.cn> <1706866812511330.14.seg@mailgw> <961cc4ad-0133-44ee-be22-ba2fbf4ebe12@kylinos.cn> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <961cc4ad-0133-44ee-be22-ba2fbf4ebe12@kylinos.cn> Fri, Feb 02, 2024 at 10:46:33AM CET, chentao@kylinos.cn wrote: >On 2024/2/1 20:47, Jiri Pirko wrote: >> Thu, Feb 01, 2024 at 11:09:24AM CET, chentao@kylinos.cn wrote: >> > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create >> > to simplify the creation of SLAB caches. >> > >> > Signed-off-by: Kunwu Chan >> >> Reviewed-by: Jiri Pirko >> >> btw, why don't you bulk these changes into patchsets of 15 patches? Or, >> given the low complexicity of the patch, just merge multiple patches >> that are changing similar locations togeter. >Sorry, I haven't sent a patchset, I'm worried about messing up. >I'll try to deal with these similar issues in the way you recommended in the >future, thank you for the reminder. Also, please fix your email client. It breaks threads. >-- >Thanks, > Kunwu >