From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B847764F; Fri, 2 Feb 2024 11:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874412; cv=none; b=TzJZad7oOT6GhGzEz/4eYqubANSTIHx2Rvwc2gg2RmZKKkwa0H0pWoZnztCoFXNHUyamoKwkszxW5X5l+hsBtblg+ltM9x/D5OPiNXiUA6EE6HFuucPYV49dWsJFOEaiK3Bzjqb9JC7jMF/he1CT+MCah32regBfnyVJlIt+KGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874412; c=relaxed/simple; bh=ld1aUV7K0aZg7cdWklhBdu+5SOi34tdiEc/1xfTmIAU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cH6aSpCNhFy0VvEuQw2A3FdDG9K3v9Lg6LHWouyC9kdbpx18cjabij1CCdVa8n8Dd4Yp1NhLNL5w+n58JBhNNyKWw76LfNluy4Ey0B9Aq6pJpB+FtVpOUUNBCP6oR5nxgJIPNeDWNDbcRl1SD1ylhsilRmj0wbnaZKAHPfduCx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=ptLmc7MV; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ptLmc7MV" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EQiNSIzGWZOhLVeY98Ti6gKM76H8cI4W2W3bGKTfEhA=; b=ptLmc7MVWQwRfnofPJ5ORYMdMH CsyUIF9bwCZa0Pd81x/m8qANoy1kHQDvzUoOJZ6IXiKTXkj36AKYohJTq0D7I8LargD/ErMnkLdwv yjX+onEq0uTXzJgqteTQhSDqWxLe0itUV8FXL6MVbSQAz+CoRipcJ2HwHPGp3ARlbV+QALTq9oSI0 BJCBrKNLiGLFx+950NY1BnYjtuddckye+7t92SjxvmByhpplsfWrSV64Zx+HiFagrJRsf5Am1cWI8 OlinlbGinZuDQzmHKSic74hNYb/PhFvuGbP5v0ex2nVqBPwf0PHVdG6++nHtMLowmo6ozKnIQAjld iFkHA7fw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43324) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rVs0H-0005uJ-1f; Fri, 02 Feb 2024 11:46:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rVs0F-0008I3-Nv; Fri, 02 Feb 2024 11:46:39 +0000 Date: Fri, 2 Feb 2024 11:46:39 +0000 From: "Russell King (Oracle)" To: arinc.unal@arinc9.com Cc: Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Bartel Eerdekens , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v3 3/7] net: dsa: mt7530: remove pad_setup function pointer Message-ID: References: <20240202-for-netnext-mt7530-improvements-2-v3-0-63d5adae99ca@arinc9.com> <20240202-for-netnext-mt7530-improvements-2-v3-3-63d5adae99ca@arinc9.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240202-for-netnext-mt7530-improvements-2-v3-3-63d5adae99ca@arinc9.com> Sender: Russell King (Oracle) On Fri, Feb 02, 2024 at 12:19:09PM +0300, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL > > The pad_setup function pointer was introduced with 88bdef8be9f6 ("net: dsa: > mt7530: Extend device data ready for adding a new hardware"). It was being > used to set up the core clock and port 6 of the MT7530 switch, and pll of > the MT7531 switch. > > All of these were moved to more appropriate locations, and it was never > used for the switch on the MT7988 SoC. Therefore, this function pointer > hasn't got a use anymore. Remove it. > > Signed-off-by: Arınç ÜNAL > Acked-by: Daniel Golle > Reviewed-by: Vladimir Oltean Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!