From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88C135FDC3; Fri, 2 Feb 2024 11:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874548; cv=none; b=QMew1ERcz3p3ArGQMAAzk5Ibpj2Xi48a/+wqg29GGmL4+pLNQPQC1iSBd9DMdCx7tkhi3iw1e1j/o9WRyxz7k/FUNpe31pR8i0AvSGLTYLhVnaUaaFAyysoT59KxBL2utwBMPU1L1wYlRZjtduvnjmOm4VZovoPOt9Az0fGt6Lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874548; c=relaxed/simple; bh=uo184ggfh3GYZsRN1j1XnH9DI8ZJwnKR9ZdCXgT5E+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=apKmrG3cV3PGdVV8DN9/DvHAaYb6I/zyliSO332Cy2T8zf2uQPEiM1eKPFaj8yO6u/hXofBlkvluHcvpI9sV0jl2CYcaSsoxhfuGXwTICWoq2OOQBr0CwZx+3/AT5DybRsLfGfWakm7Nosxc7FQeyT9n/W8ekyljvcOXNrMTOFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=Kz8RsV3J; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Kz8RsV3J" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+wtvAtiCrXRnVQNeDR1xCYojq9FyDB3BcqW6RXyS2RA=; b=Kz8RsV3J1ZNrdGoNzEEZkj0pZt aUh/UPiOQh2sXYeMDp480rblngXiTDEjCPwG6p7D89Lw8ZhKnAev5241ygabQ3vSVZO3U+3u5wY1T X7i+5dCOinMbOWnET3oByxwHpY62sYbkfZ6B8DnVFc4/5GzJLgQ83tnPjdfVOcSBG+No96+zULoBL 5+xYWQ23mk9U1kAOgWZow/qhpbDauIp2aE/Pjc6sgh1TRRe/GHRjsd8WvG3Zfz0YhmRCLGG9PNBrp JcvS+ROKFA5VOXE+VVG7aTGKpLNJkePcsTdxhghJeP5rf6H4RG9HoAWSntOlXW/iBxR9kZkba1pdK 7YYB0e3A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52690) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rVs2S-0005v7-2X; Fri, 02 Feb 2024 11:48:56 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rVs2Q-0008ID-NC; Fri, 02 Feb 2024 11:48:54 +0000 Date: Fri, 2 Feb 2024 11:48:54 +0000 From: "Russell King (Oracle)" To: arinc.unal@arinc9.com Cc: Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Bartel Eerdekens , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v3 4/7] net: dsa: mt7530: move XTAL check to mt7530_setup() Message-ID: References: <20240202-for-netnext-mt7530-improvements-2-v3-0-63d5adae99ca@arinc9.com> <20240202-for-netnext-mt7530-improvements-2-v3-4-63d5adae99ca@arinc9.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240202-for-netnext-mt7530-improvements-2-v3-4-63d5adae99ca@arinc9.com> Sender: Russell King (Oracle) On Fri, Feb 02, 2024 at 12:19:10PM +0300, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL > > The crystal frequency concerns the switch core. The frequency should be > checked when the switch is being set up so the driver can reject the > unsupported hardware earlier and without requiring port 6 to be used. > > Move it to mt7530_setup(). Drop the unnecessary function printing. > > Signed-off-by: Arınç ÜNAL > Reviewed-by: Andrew Lunn > Reviewed-by: Vladimir Oltean I would prefer this to be earlier in the series, before patch 2 which moves mt7530_setup_port6() to be called from mac_config(). mac_config() is supposed to be configuration error-free - in other words, all state should have been checked before hand. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!