From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4DC113D4F7; Fri, 2 Feb 2024 11:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874744; cv=none; b=Y4wIAfRpFoGjzybxKWhssmDN19kwji4V3dM8G8mMuS0RgIrGy03lus/8KC9nSoTUMUB0tqC2LznZXaiA4IX7gYYqijfSol1iwN5o+XMQ5iCdHCJXWcQVKeBNupKRPVHgEzghvWqK5abawmtyKiPc01gtS+z6V8TQX9nxgKzCJVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706874744; c=relaxed/simple; bh=WWpj7IIOmpVjFPX3K3o71FGW0pD4t4+22/QypjCBsEM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W1cT47qZDd2NSSvkDarK4mLCnpspKXCVsttG/l8rS3JpK0zGzGeCAxC57WnHJ2nERqzH/R+2lMZwc+fRRl94OtfJdJGXnsRA4/SlLqYR85p7r34SzFARRi/q5iuNuQtFpFbPha46c0gE2rSyTSfLGlFig+pDnuW6Lql07uQ57cQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=aj0xf2f5; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="aj0xf2f5" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bdMRNfuOlYWXCZSbX3qtLpZ6mLae9pQYUL0x6nsWQvA=; b=aj0xf2f5Jf2gkGwMowWngx4HiC veb5AYlQO/gjHSyzr2p8XpEQgkWsB0lsh3TM5rAP/Mpdht38o6EWIGmXnsUz/PqYitIR5wzPJAEbC toUWEczWTq0ZuJqe2A7aqJ3i16YHPbXjue1LuKpi5i+F4ob58eYNaoO1QzEsmJuFHu46xx3BVAHv6 DmF9DdS6Pa26OxbI131SJYNL0nCcWks/SWrdJv4J5wFc3jtLYlk6bdwiR3LtHvG0gc8MiNaorp+n7 /ehLDkav139ssUKFj79VIyRJwYmGjvVrVHM5mdAPsc4R7e6t9dMKIJU4m5Y2LKkJMHzL1E8GfQYET JG72R3CQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34052) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rVs5d-0005vu-2u; Fri, 02 Feb 2024 11:52:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rVs5b-0008IR-Tm; Fri, 02 Feb 2024 11:52:11 +0000 Date: Fri, 2 Feb 2024 11:52:11 +0000 From: "Russell King (Oracle)" To: arinc.unal@arinc9.com Cc: Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Bartel Eerdekens , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v3 7/7] net: dsa: mt7530: do not clear config->supported_interfaces Message-ID: References: <20240202-for-netnext-mt7530-improvements-2-v3-0-63d5adae99ca@arinc9.com> <20240202-for-netnext-mt7530-improvements-2-v3-7-63d5adae99ca@arinc9.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240202-for-netnext-mt7530-improvements-2-v3-7-63d5adae99ca@arinc9.com> Sender: Russell King (Oracle) On Fri, Feb 02, 2024 at 12:19:13PM +0300, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL > > There's no need to clear the config->supported_interfaces bitmap before > reporting the supported interfaces as all bits in the bitmap will already > be initialized to zero when the phylink_config structure is allocated. The > "config" pointer points to &dp->phylink_config, and "dp" is allocated by > dsa_port_touch() with kzalloc(), so all its fields are filled with zeroes. > > There's no code that would change the bitmap beforehand. Remove it. > > Signed-off-by: Arınç ÜNAL > Acked-by: Daniel Golle > Reviewed-by: Vladimir Oltean Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!