From: Guillaume Nault <gnault@redhat.com>
To: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Cc: Michal Ostrowski <mostrows@earthlink.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
"syzbot+6bdfd184eac7709e5cc9@syzkaller.appspotmail.com"
<syzbot+6bdfd184eac7709e5cc9@syzkaller.appspotmail.com>
Subject: Re: [PATCH net] pppoe: Fix memory leak in pppoe_sendmsg()
Date: Thu, 15 Feb 2024 14:35:55 +0100 [thread overview]
Message-ID: <Zc4TOy4FPn1YaKb/@debian> (raw)
In-Reply-To: <20240214085814.3894917-1-Ilia.Gavrilov@infotecs.ru>
On Wed, Feb 14, 2024 at 09:01:50AM +0000, Gavrilov Ilia wrote:
> syzbot reports a memory leak in pppoe_sendmsg [1].
>
> The problem is in the pppoe_recvmsg() function that handles errors
> in the wrong order. For the skb_recv_datagram() function, check
> the pointer to skb for NULL first, and then check the 'error' variable,
> because the skb_recv_datagram() function can set 'error'
> to -EAGAIN in a loop but return a correct pointer to socket buffer
> after a number of attempts, though 'error' remains set to -EAGAIN.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2024-02-15 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 9:01 [PATCH net] pppoe: Fix memory leak in pppoe_sendmsg() Gavrilov Ilia
2024-02-15 13:35 ` Guillaume Nault [this message]
2024-02-15 16:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc4TOy4FPn1YaKb/@debian \
--to=gnault@redhat.com \
--cc=Ilia.Gavrilov@infotecs.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+6bdfd184eac7709e5cc9@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).