From: Sasha Levin <sashal@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: stable@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>, Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"open list:BROADCOM GENET ETHERNET DRIVER"
<bcm-kernel-feedback-list@broadcom.com>,
"open list:BROADCOM GENET ETHERNET DRIVER"
<netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH stable 5.15 v2] net: bcmgenet: Fix EEE implementation
Date: Sun, 11 Feb 2024 11:36:20 -0500 [thread overview]
Message-ID: <Zcj3hF6uywZcTPX4@sashalap> (raw)
In-Reply-To: <20240208190605.3341379-2-florian.fainelli@broadcom.com>
On Thu, Feb 08, 2024 at 11:06:05AM -0800, Florian Fainelli wrote:
>[ Upstream commit a9f31047baca57d47440c879cf259b86f900260c ]
>
>We had a number of short comings:
>
>- EEE must be re-evaluated whenever the state machine detects a link
> change as wight be switching from a link partner with EEE
> enabled/disabled
>
>- tx_lpi_enabled controls whether EEE should be enabled/disabled for the
> transmit path, which applies to the TBUF block
>
>- We do not need to forcibly enable EEE upon system resume, as the PHY
> state machine will trigger a link event that will do that, too
>
>Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
>Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
>Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>Signed-off-by: Sasha Levin <sashal@kernel.org>
>Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
It doesn't look like this one applies to 5.15...
--
Thanks,
Sasha
next prev parent reply other threads:[~2024-02-11 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 19:06 [PATCH stable 5.4 v2] net: bcmgenet: Fix EEE implementation Florian Fainelli
2024-02-08 19:06 ` [PATCH stable 5.15 " Florian Fainelli
2024-02-11 16:36 ` Sasha Levin [this message]
2024-02-12 1:49 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zcj3hF6uywZcTPX4@sashalap \
--to=sashal@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).