From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 090F11DFEF; Sun, 11 Feb 2024 16:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707669383; cv=none; b=ZGYbhZgOm85jHg6ndafWWKu3NHzk1ye1bFuYW+MYxbOwJCmuszXuMgaqycaymIgmv5kFsamDKp+jZSRasHV+aXTAEQkyH6VxFf5IDPHcrt7w7URIZqBv0kStfu2EYto/O5gnlqaQAvLo7DLbk3g1LLt/3LCYhkj/2JVm7bluC08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707669383; c=relaxed/simple; bh=BVT7c5MMwoanGGQVtjw+M5JfeoluaC7HDWDxAzZAEyg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LgpNv2R3YOhfp6lZbdXYwNr8CssqAMj2g0SNjzfGF6nQA3qTF5kgc67FQ1wO3kkFWaFGBax2vDHVrGEzZKHGTY1WJkY/MU++HAZMA9E3J6o+D0XxGcmmP0AjoW6MocfGMBHgHU1/Ze0KLA9lkBBuamiVaBr+oXhnGKlSfVQ7uGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GXE/ixzo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GXE/ixzo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E63DC433C7; Sun, 11 Feb 2024 16:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707669382; bh=BVT7c5MMwoanGGQVtjw+M5JfeoluaC7HDWDxAzZAEyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GXE/ixzolu0k8wKk/Vk6a7Fel7WWw+xxHDcbCPywbSyyo83tTRz477KXJUWMxpXvf Tr1MXoK+sD403mAy4u2WLgduc5yUbSq8mXGAZ41zGRqxZlklydfPn2uirTjb+A38cv 4kxcPMlLJ1dGLJxIa2DAPO3EmgFPIH4m9QZ4ZV/JqOGEc8MY4SMxuwl66j6r7DLiE4 PODM2fF5Rfh2eDLFzzxVxsV6EwDQslfZxBRq3+kY+e8GuWHKr4qd3ccjm2g+mjIALS pMFPyjIkh/eo+Ylq6zScv089vlj50F4L/BZg2Nh6IIqO46IqsbixZ0qFymqZSmNbrG AZwBVKL2aUKEw== Date: Sun, 11 Feb 2024 11:36:20 -0500 From: Sasha Levin To: Florian Fainelli Cc: stable@vger.kernel.org, Russell King , Jakub Kicinski , Doug Berger , Florian Fainelli , "David S. Miller" , "open list:BROADCOM GENET ETHERNET DRIVER" , "open list:BROADCOM GENET ETHERNET DRIVER" , open list Subject: Re: [PATCH stable 5.15 v2] net: bcmgenet: Fix EEE implementation Message-ID: References: <20240208190605.3341379-1-florian.fainelli@broadcom.com> <20240208190605.3341379-2-florian.fainelli@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240208190605.3341379-2-florian.fainelli@broadcom.com> On Thu, Feb 08, 2024 at 11:06:05AM -0800, Florian Fainelli wrote: >[ Upstream commit a9f31047baca57d47440c879cf259b86f900260c ] > >We had a number of short comings: > >- EEE must be re-evaluated whenever the state machine detects a link > change as wight be switching from a link partner with EEE > enabled/disabled > >- tx_lpi_enabled controls whether EEE should be enabled/disabled for the > transmit path, which applies to the TBUF block > >- We do not need to forcibly enable EEE upon system resume, as the PHY > state machine will trigger a link event that will do that, too > >Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support") >Signed-off-by: Florian Fainelli >Reviewed-by: Russell King (Oracle) >Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com >Signed-off-by: Jakub Kicinski >Signed-off-by: Sasha Levin >Signed-off-by: Florian Fainelli It doesn't look like this one applies to 5.15... -- Thanks, Sasha