netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] 9p/trans_fd: remove Excess kernel-doc comment
@ 2024-02-12  4:33 Randy Dunlap
  2024-02-12 12:13 ` Dominique Martinet
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2024-02-12  4:33 UTC (permalink / raw)
  To: netdev
  Cc: Randy Dunlap, Eric Van Hensbergen, Latchesar Ionkov,
	Dominique Martinet, v9fs, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Simon Horman

Remove the "@req" kernel-doc description since there is not 'req'
member in the struct p9_conn.

Fixes one kernel-doc warning:
trans_fd.c:133: warning: Excess struct member 'req' description in 'p9_conn'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Cc: Dominique Martinet <asmadeus@codewreck.org>
Cc: v9fs@lists.linux.dev
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
---
v2: add Simon's Reviewed-by;
    rebase & resend;

 net/9p/trans_fd.c |    1 -
 1 file changed, 1 deletion(-)

diff -- a/net/9p/trans_fd.c b/net/9p/trans_fd.c
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -95,7 +95,6 @@ struct p9_poll_wait {
  * @unsent_req_list: accounting for requests that haven't been sent
  * @rreq: read request
  * @wreq: write request
- * @req: current request being processed (if any)
  * @tmp_buf: temporary buffer to read in header
  * @rc: temporary fcall for reading current frame
  * @wpos: write position for current frame

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] 9p/trans_fd: remove Excess kernel-doc comment
  2024-02-12  4:33 [PATCH v2] 9p/trans_fd: remove Excess kernel-doc comment Randy Dunlap
@ 2024-02-12 12:13 ` Dominique Martinet
  0 siblings, 0 replies; 2+ messages in thread
From: Dominique Martinet @ 2024-02-12 12:13 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: netdev, Eric Van Hensbergen, Latchesar Ionkov, v9fs,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman

Randy Dunlap wrote on Sun, Feb 11, 2024 at 08:33:41PM -0800:
> Remove the "@req" kernel-doc description since there is not 'req'
> member in the struct p9_conn.
> 
> Fixes one kernel-doc warning:
> trans_fd.c:133: warning: Excess struct member 'req' description in 'p9_conn'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Sorry for the lack of reply, I intended to take the patch when the next
""real"" patch comes in but it doesn't look like we'll get much activity
this cycle so I've just queued it up to -next.

Thanks!

FWIW, I contemplated adding
Fixes: 6d35190f3953 ("9p: Rename req to rreq in trans_fd")
but that's basically been forever so I don't think anyone will care
about backports -- and I'm both surprised and ashamed I didn't see this
W=1 warning earlier, I thought I regularly build with that...

-- 
Dominique

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-12 12:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-12  4:33 [PATCH v2] 9p/trans_fd: remove Excess kernel-doc comment Randy Dunlap
2024-02-12 12:13 ` Dominique Martinet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).