From: Tom Parkin <tparkin@katalix.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: James Chapman <jchapman@katalix.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
edumazet@google.com, gnault@redhat.com, davem@davemloft.net,
pabeni@redhat.com, corbet@lwn.net, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3] PPPoL2TP: Add more code snippets
Date: Mon, 12 Feb 2024 21:33:48 +0000 [thread overview]
Message-ID: <ZcqOvDgXsG2W8t8l@katalix.com> (raw)
In-Reply-To: <20240209082046.6a87f7f8@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Fri, Feb 09, 2024 at 08:20:46 -0800, Jakub Kicinski wrote:
> On Sat, 3 Feb 2024 23:35:13 +0100 Samuel Thibault wrote:
> > The existing documentation was not telling that one has to create a PPP
> > channel and a PPP interface to get PPPoL2TP data offloading working.
> >
> > Also, tunnel switching was not mentioned, so that people were thinking
> > it was not supported, while it actually is.
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> James, Tom, looks good?
Sorry for the silence -- I think for v2 we had some discussion of
whether the PPPIOCBRIDGECHAN docs really belonged in l2tp.rst or not
and I wasn't sure whether the same issue would be raised again.
For me I'm happy enough having it mentioned in the l2tp documentation,
so long as the example is clear and accurate. I've responded to the
patch now with a couple of suggestions on that front.
Thanks,
Tom
--
Tom Parkin
Katalix Systems Ltd
https://katalix.com
Catalysts for your Embedded Linux software development
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-02-12 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 22:35 [PATCHv3] PPPoL2TP: Add more code snippets Samuel Thibault
2024-02-09 16:20 ` Jakub Kicinski
2024-02-12 21:33 ` Tom Parkin [this message]
2024-02-12 21:25 ` Tom Parkin
2024-02-12 22:21 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcqOvDgXsG2W8t8l@katalix.com \
--to=tparkin@katalix.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).