Re: [iwl-next v1 10/15] ice: create port representor for SF

[Jiri Pirko <jiri@resnulli.us>]

Tue, Feb 13, 2024 at 08:27:19AM CET, michal.swiatkowski@linux.intel.com wrote:
>Store subfunction and VF pointer in port representor structure as an
>union. Add port representor type to distinguish between each of them.
>
>Keep the same flow of port representor creation, but instead of general
>attach function create helpers for VF and subfunction attach function.
>
>Type of port representor can be also known based on VSI type, but it
>is more clean to have it directly saved in port representor structure.
>
>Create port representor when subfunction port is activated.
>
>Add devlink lock for whole VF port representor creationi and destruction.
>It is done to be symmetric with what happens in case of SF port
>representor. SF port representor is always added or removed with devlink
>lock taken. Doing the same with VF port representor simplify logic.
>
>Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
>Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
>---
> .../intel/ice/devlink/ice_devlink_port.c      |   4 +-
> .../intel/ice/devlink/ice_devlink_port.h      |   1 +
> drivers/net/ethernet/intel/ice/ice_eswitch.c  |  82 ++++++++++---
> drivers/net/ethernet/intel/ice/ice_eswitch.h  |  22 +++-
> drivers/net/ethernet/intel/ice/ice_repr.c     | 110 +++++++++++-------
> drivers/net/ethernet/intel/ice/ice_repr.h     |  21 +++-
> drivers/net/ethernet/intel/ice/ice_sf_eth.c   |  11 ++
> drivers/net/ethernet/intel/ice/ice_sriov.c    |   4 +-
> drivers/net/ethernet/intel/ice/ice_txrx.c     |   2 +-
> drivers/net/ethernet/intel/ice/ice_vf_lib.c   |   4 +-
> 10 files changed, 184 insertions(+), 77 deletions(-)

Again, please split.