From: Stanislav Fomichev <sdf@google.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Samiullah Khawaja <skhawaja@google.com>
Subject: Re: [PATCH net-next] net: call skb_defer_free_flush() from __napi_busy_loop()
Date: Tue, 27 Feb 2024 13:07:25 -0800 [thread overview]
Message-ID: <Zd5PDb7WQ2o8kx8C@google.com> (raw)
In-Reply-To: <20240227210105.3815474-1-edumazet@google.com>
On 02/27, Eric Dumazet wrote:
> skb_defer_free_flush() is currently called from net_rx_action()
> and napi_threaded_poll().
>
> We should also call it from __napi_busy_loop() otherwise
> there is the risk the percpu queue can grow until an IPI
> is forced from skb_attempt_defer_free() adding a latency spike.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Samiullah Khawaja <skhawaja@google.com>
> Cc: Stanislav Fomichev <sdf@google.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
Thank you!
next prev parent reply other threads:[~2024-02-27 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:01 [PATCH net-next] net: call skb_defer_free_flush() from __napi_busy_loop() Eric Dumazet
2024-02-27 21:07 ` Stanislav Fomichev [this message]
2024-02-28 11:08 ` Jiri Pirko
2024-02-29 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd5PDb7WQ2o8kx8C@google.com \
--to=sdf@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhawaja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).