From: Jiri Pirko <jiri@resnulli.us>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Naman Gulati <namangulati@google.com>,
eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] tcp: remove some holes in struct tcp_sock
Date: Wed, 28 Feb 2024 08:56:25 +0100 [thread overview]
Message-ID: <Zd7nKRuwjcBRWhT8@nanopsycho> (raw)
In-Reply-To: <20240227192721.3558982-1-edumazet@google.com>
Tue, Feb 27, 2024 at 08:27:21PM CET, edumazet@google.com wrote:
>By moving some fields around, this patch shrinks
>holes size from 56 to 32, saving 24 bytes on 64bit arches.
>
>After the patch pahole gives the following for 'struct tcp_sock':
>
> /* size: 2304, cachelines: 36, members: 162 */
> /* sum members: 2234, holes: 6, sum holes: 32 */
> /* sum bitfield members: 34 bits, bit holes: 5, sum bit holes: 14 bits */
> /* padding: 32 */
> /* paddings: 3, sum paddings: 10 */
> /* forced alignments: 1, forced holes: 1, sum forced holes: 12 */
>
>Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2024-02-28 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 19:27 [PATCH net-next] tcp: remove some holes in struct tcp_sock Eric Dumazet
2024-02-28 7:56 ` Jiri Pirko [this message]
2024-02-29 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd7nKRuwjcBRWhT8@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=namangulati@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox