From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B980D149001 for ; Wed, 28 Feb 2024 13:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709126290; cv=none; b=MBAz2dddqUgpWdDEeEQ1jObU5ZaBgB7/Ma5asXXRGVm4OD5TIA+iLzm7z0cQE2T7sKKo7u6rlms8Tqm7Pho6SlHxfCSSdksjMpjgiT94e1L55B+sRAODzItRwO6w9T8bdyvUs5YVVy1lDXdGZI6EQRFjlr+suVDS4jjYjnq56bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709126290; c=relaxed/simple; bh=T9bbLfFirb6Q1nmM2phZcrUMaD0qpbEtTd0EvaBl3FM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HV6yWzoC5QUtAr8TQoYmwdAloCVKBgEP49awTc5rXli4pmIAFy3AtvceClF71zHMpIENy3xm1AyYr494y1D5F2UTBM+x2n7EFmyxqzAHlrZPiCz6ZAq3avjVrtePXdVQuL+Zn28NUs+4I2oxSPNo05MnRe8XHawAjWP4btL2VSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=QLZ/qBuJ; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="QLZ/qBuJ" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5661b7b1f51so4050672a12.2 for ; Wed, 28 Feb 2024 05:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1709126286; x=1709731086; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T9bbLfFirb6Q1nmM2phZcrUMaD0qpbEtTd0EvaBl3FM=; b=QLZ/qBuJfbnVkACL67qi5CM5l2c5DUHAAQvn6jxgBazY+u+Uc6dK4xMlXdULIt4K1+ cjSTITePHBNifoSNyfeG35lpr9VejIJYmD9Da1R5C4pv1C3H4GWEcvRSG/J4IXFLouuM cufOW8Y03Qa+ntkmXoEttbApErms30V7HWAflM4vkFHSnMQ79ocmfVbXh/K87yZAwJ4c EwY7sI4x8aQiuiAAzFbIY94J6mWdhWNDwFXCEZbaQcrBJIQbbXECaVPEmhv+yZBOjnVu TFbjBf3DURhmtM8YSgPl1Xd80aa2RUoU8r/kYZwhEL/Eovk8Byx1bEQa7luXACNx7FLB YQVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709126286; x=1709731086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T9bbLfFirb6Q1nmM2phZcrUMaD0qpbEtTd0EvaBl3FM=; b=ADibzG2Cr9h/9hX5obwA2nydcpw7mV2O8JmjpHxN7UYn8kZjPrSXQficmGKbdhwnnh kwe2lVFuHoGJ5NDXsFm3NAiO5rjWcDmv4IXmh9DyQEWMruLJtHOwxNsX9x27fxDhdTBL xnnFM4q888vsDv3rHRCnicJFqMvbJcmOq4YeJaMNqNmnanxUpPybpw/joZOctQk2XOp1 aoZWkulbLaEN0B5Pk/lGXNP37sLoChKd9YF0YTwVa5kGjKoMRKlRaVckh56neV2S7n1i pp3zrBCNQYgd8bTUuiOJYjcoJIQ/jk/do3udTHJ6Ip6DNjabjZkG57ZHAwz3cBJ8JYfQ q5LQ== X-Forwarded-Encrypted: i=1; AJvYcCWcMUD11cymVgyxzELNSs7NkWt1j40brM7Keapo70QoHMDbdko6aIovXG+pYFqm7qdoPEKDuUtR3RWJIwSxS7qiC42rJS9l X-Gm-Message-State: AOJu0Yxgenv1ML5nr1KiuiixCbAHOqwRSF8osFLIaPLNB4TNZHJ5DAsQ X6CyWWqu79g8Dhjn7Bl67H4UqIyPkAORfE6yLFdRIUdEGfe33gZN82ox0dN1R78= X-Google-Smtp-Source: AGHT+IHdtqRhyNQ/e0c4lOXcJPjqGyZ/p7KGJ83ZXMCkNFH4ojscfmGB3OOdDdX9tI4QyD8O+M4oCw== X-Received: by 2002:a17:906:34cb:b0:a40:2999:5404 with SMTP id h11-20020a17090634cb00b00a4029995404mr8669065ejb.3.1709126286223; Wed, 28 Feb 2024 05:18:06 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id gw7-20020a170906f14700b00a3eb1b1896bsm1837802ejb.58.2024.02.28.05.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 05:18:05 -0800 (PST) Date: Wed, 28 Feb 2024 14:18:02 +0100 From: Jiri Pirko To: Oleksij Rempel Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net v1 1/1] net: lan78xx: fix runtime PM count underflow on link stop Message-ID: References: <20240228124517.1702476-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240228124517.1702476-1-o.rempel@pengutronix.de> Wed, Feb 28, 2024 at 01:45:17PM CET, o.rempel@pengutronix.de wrote: >Current driver has some asymmetry in the runtime PM calls. On lan78xx_open() >it will call usb_autopm_get() and unconditionally usb_autopm_put(). And >on lan78xx_stop() it will call only usb_autopm_put(). So far, it was >working only because this driver do not activate autosuspend by default, >so it was visible only by warning "Runtime PM usage count underflow!". > >Since, with current driver, we can't use runtime PM with active link, >execute lan78xx_open()->usb_autopm_put() only in error case. Otherwise, >keep ref counting high as long as interface is open. > >Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") >Signed-off-by: Oleksij Rempel Reviewed-by: Jiri Pirko