From: Jiri Pirko <jiri@resnulli.us>
To: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Shiming Cheng (成诗明)" <Shiming.Cheng@mediatek.com>
Subject: Re: [PATCH net v3] ipv6:flush ipv6 route cache when rule is changed
Date: Wed, 28 Feb 2024 16:50:43 +0100 [thread overview]
Message-ID: <Zd9WU1bpoOlR9de7@nanopsycho> (raw)
In-Reply-To: <c9fe5b133393efd179c54f3d7bed78d16b14e4ab.camel@mediatek.com>
Wed, Feb 28, 2024 at 04:38:56PM CET, Lena.Wang@mediatek.com wrote:
>From: Shiming Cheng <shiming.cheng@mediatek.com>
>
>When rule policy is changed, ipv6 socket cache is not refreshed.
>The sock's skb still uses a outdated route cache and was sent to
>a wrong interface.
>
>To avoid this error we should update fib node's version when
>rule is changed. Then skb's route will be reroute checked as
>route cache version is already different with fib node version.
>The route cache is refreshed to match the latest rule.
>
>Signed-off-by: Shiming Cheng <shiming.cheng@mediatek.com>
>Signed-off-by: Lena Wang <lena.wang@mediatek.com>
1) You are still missing Fixes tags, I don't know what to say.
2) Re patch subject:
"ipv6:flush ipv6 route cache when rule is changed"
Could it be:
"ipv6: fib6_rules: flush route cache when rule is changed"
? please.
3) Could you please honor the 24h hours resubmission rule:
https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html#tl-dr
pw-bot: cr
next prev parent reply other threads:[~2024-02-28 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 15:38 [PATCH net v3] ipv6:flush ipv6 route cache when rule is changed Lena Wang (王娜)
2024-02-28 15:50 ` Jiri Pirko [this message]
2024-02-29 8:24 ` Lena Wang (王娜)
2024-02-29 8:39 ` Jiri Pirko
2024-02-29 8:47 ` Lena Wang (王娜)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd9WU1bpoOlR9de7@nanopsycho \
--to=jiri@resnulli.us \
--cc=Lena.Wang@mediatek.com \
--cc=Shiming.Cheng@mediatek.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).