From: Jiri Pirko <jiri@resnulli.us>
To: Jianbo Liu <jianbol@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Cosmin Ratiu <cratiu@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Paul Blakey <paulb@nvidia.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH net] net/sched: flower: Add lock protection when remove filter handle
Date: Tue, 20 Feb 2024 10:17:26 +0100 [thread overview]
Message-ID: <ZdRuJuUKALW1Xe9Q@nanopsycho> (raw)
In-Reply-To: <20240220085928.9161-1-jianbol@nvidia.com>
Tue, Feb 20, 2024 at 09:59:28AM CET, jianbol@nvidia.com wrote:
>As IDR can't protect itself from the concurrent modification, place
>idr_remove() under the protection of tp->lock.
>
>Fixes: 08a0063df3ae ("net/sched: flower: Move filter handle initialization earlier")
>Signed-off-by: Jianbo Liu <jianbol@nvidia.com>
>Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
>Reviewed-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2024-02-20 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 8:59 [PATCH net] net/sched: flower: Add lock protection when remove filter handle Jianbo Liu
2024-02-20 9:17 ` Jiri Pirko [this message]
2024-02-20 14:53 ` Jamal Hadi Salim
2024-02-21 8:06 ` Jianbo Liu
2024-02-22 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdRuJuUKALW1Xe9Q@nanopsycho \
--to=jiri@resnulli.us \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jianbol@nvidia.com \
--cc=kuba@kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulb@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).