RE: [patch net-next v2 0/3] tools: ynl: couple of cmdline enhancements

Keller, Jacob E
2024-02-21T22:29:52Z

> -----Original Message-----
> From: Jiri Pirko <jiri@resnulli.us>
> Sent: Wednesday, February 21, 2024 7:54 AM
> To: netdev@vger.kernel.org
> Cc: kuba@kernel.org; pabeni@redhat.com; davem@davemloft.net;
> edumazet@google.com; Keller, Jacob E <jacob.e.keller@intel.com>;
> swarupkotikalapudi@gmail.com; donald.hunter@gmail.com; sdf@google.com;
> lorenzo@kernel.org; alessandromarcolini99@gmail.com
> Subject: [patch net-next v2 0/3] tools: ynl: couple of cmdline enhancements
>
> From: Jiri Pirko <jiri@nvidia.com>
>
> This is part of the original "netlink: specs: devlink: add the rest of
> missing attribute definitions" set which was rejected [1]. These three
> patches enhances the cmdline user comfort, allowing to pass flag
> attribute with bool values and enum names instead of scalars.
>
> [1] https://lore.kernel.org/all/20240220181004.639af931@kernel.org/
>

This series looks straight forward to me.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> ---
> v1->v2:
> - only first 3 patches left, the rest it cut out
> - see changelog of individual patches
>
> Jiri Pirko (3):
> tools: ynl: allow user to specify flag attr with bool values
> tools: ynl: process all scalar types encoding in single elif statement
> tools: ynl: allow user to pass enum string instead of scalar value
>
> tools/net/ynl/lib/ynl.py | 39 ++++++++++++++++++++++++++++++---------
> 1 file changed, 30 insertions(+), 9 deletions(-)
>
> --
> 2.43.2