From: Stanislav Fomichev <sdf@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: amritha.nambiar@intel.com, davem@davemloft.net,
netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
danielj@nvidia.com, mst@redhat.com, michael.chan@broadcom.com
Subject: Re: [RFC net-next 1/3] netdev: add per-queue statistics
Date: Thu, 22 Feb 2024 20:32:39 -0800 [thread overview]
Message-ID: <Zdgf3EkGEWRfOjq5@google.com> (raw)
In-Reply-To: <20240222174407.5949cf90@kernel.org>
On 02/22, Jakub Kicinski wrote:
> On Thu, 22 Feb 2024 16:29:08 -0800 Nambiar, Amritha wrote:
> > Thanks, this almost has all the bits to also lookup stats for a single
> > queue with --do stats-get with a queue id and type.
>
> We could without the projection. The projection (BTW not a great name,
> couldn't come up with a better one.. split? dis-aggregation? view?
> un-grouping?) "splits" a single object (netdev stats) across components
How about "scope" ? Device scope. Queue scope.
> (queues). I was wondering if at some point we may add another
> projection, splitting a queue. And then a queue+id+projection would
> actually have to return multiple objects. So maybe it's more consistent
> to just not support do at all for this op, and only support dump?
>
> We can support filtered dump on ifindex + queue id + type, and expect
> it to return one object for now.
>
> Not 100% sure so I went with the "keep it simple, we can add more later"
> approach.
next prev parent reply other threads:[~2024-02-23 4:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 22:36 [RFC net-next 0/3] netdev: add per-queue statistics Jakub Kicinski
2024-02-22 22:36 ` [RFC net-next 1/3] " Jakub Kicinski
2024-02-23 0:23 ` Nambiar, Amritha
2024-02-23 1:37 ` Jakub Kicinski
2024-02-23 20:40 ` Nambiar, Amritha
2024-02-23 0:29 ` Nambiar, Amritha
2024-02-23 1:44 ` Jakub Kicinski
2024-02-23 4:32 ` Stanislav Fomichev [this message]
2024-02-23 9:22 ` Vadim Fedorenko
2024-02-23 20:51 ` Nambiar, Amritha
2024-02-24 0:13 ` Jakub Kicinski
2024-02-26 19:42 ` Nambiar, Amritha
2024-02-22 22:36 ` [RFC net-next 2/3] netdev: add queue stat for alloc failures Jakub Kicinski
2024-02-22 22:36 ` [RFC net-next 3/3] eth: bnxt: support per-queue statistics Jakub Kicinski
2024-02-23 0:29 ` Nambiar, Amritha
2024-02-23 1:33 ` Jakub Kicinski
2024-02-23 20:42 ` Nambiar, Amritha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdgf3EkGEWRfOjq5@google.com \
--to=sdf@google.com \
--cc=amritha.nambiar@intel.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).