From: Christoph Hellwig <hch@infradead.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
xieyongji@bytedance.com, axboe@kernel.dk,
gregkh@linuxfoundation.org, brauner@kernel.org,
lstoakes@gmail.com, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
david.marchand@redhat.com
Subject: Re: [PATCH] vduse: implement DMA sync callbacks
Date: Fri, 23 Feb 2024 00:03:01 -0800 [thread overview]
Message-ID: <ZdhRNeJRo1UaZt2F@infradead.org> (raw)
In-Reply-To: <20240222152541-mutt-send-email-mst@kernel.org>
On Thu, Feb 22, 2024 at 03:29:10PM -0500, Michael S. Tsirkin wrote:
> In a sense ... but on the other hand, the "fake DMA" metaphor seems to
> work surprisingly well, like in this instance - internal bounce buffer
> looks a bit like non-coherent DMA. A way to make this all prettier
> would I guess be to actually wrap all of DMA with virtio wrappers which
> would all go if () dma_... else vduse_...; or something to this end. A
> lot of work for sure, and is it really worth it? if the only crazy
> driver is vduse I'd maybe rather keep the crazy hacks local there ...
Well, vduse is the only driver that does this hack - we had a few more
and we got rid of it. It basically is the only thing preventing us
from doing direct calls into the iommu code and compile out dma_ops
entirely for non-Xen builds on the common architectures.
So yes, I'd really like to see it gone rather sooner than later.
prev parent reply other threads:[~2024-02-23 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 17:06 [PATCH] vduse: implement DMA sync callbacks Maxime Coquelin
2024-02-20 9:01 ` Christoph Hellwig
2024-02-21 8:47 ` Maxime Coquelin
2024-02-22 20:29 ` Michael S. Tsirkin
2024-02-23 8:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdhRNeJRo1UaZt2F@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=david.marchand@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).