[PATCH net-next] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner

[PATCH net-next] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner

[Jones Syue 薛懷宗]

They are verifying the same thing: if aggregator has a partner or not.
Replaces macro with inline function would look more clear to understand.

Signed-off-by: Jones Syue <jonessyue@qnap.com>
---
 drivers/net/bonding/bond_3ad.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index f2942e8..eb3c2d1 100644
--- a/drivers/net/bonding/bond_3ad.c
+++ b/drivers/net/bonding/bond_3ad.c
@@ -2036,9 +2036,7 @@ static void ad_enable_collecting(struct port *port)
  */
 static void ad_disable_distributing(struct port *port, bool *update_slave_arr)
 {
-	if (port->aggregator &&
-	    !MAC_ADDRESS_EQUAL(&port->aggregator->partner_system,
-			       &(null_mac_addr))) {
+	if (port->aggregator && __agg_has_partner(port->aggregator)) {
 		slave_dbg(port->slave->bond->dev, port->slave->dev,
 			  "Disabling distributing on port %d (LAG %d)\n",
 			  port->actor_port_number,
@@ -2078,9 +2076,7 @@ static void ad_enable_collecting_distributing(struct port *port,
 static void ad_disable_collecting_distributing(struct port *port,
 					       bool *update_slave_arr)
 {
-	if (port->aggregator &&
-	    !MAC_ADDRESS_EQUAL(&(port->aggregator->partner_system),
-			       &(null_mac_addr))) {
+	if (port->aggregator && __agg_has_partner(port->aggregator)) {
 		slave_dbg(port->slave->bond->dev, port->slave->dev,
 			  "Disabling port %d (LAG %d)\n",
 			  port->actor_port_number,
-- 
2.1.4

Re: [PATCH net-next] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner

[Jakub Kicinski]

On Thu, 22 Feb 2024 09:04:36 +0000 Jones Syue 薛懷宗 wrote:
> To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>

You need to CC the maintainers. Please use ./script/get_maintainer.pl
to identify the right recipients and resend the patch.
-- 
pw-bot: cr

Re: [PATCH net-next] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner

[Jones Syue 薛懷宗]

> You need to CC the maintainers. Please use ./script/get_maintainer.pl
> to identify the right recipients and resend the patch.

Thank you for kindly feedback! Sure will resend with correct CC :)

--

Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.

Re: [PATCH net-next] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner

[Jiri Pirko]

Fri, Feb 23, 2024 at 04:54:11AM CET, jonessyue@qnap.com wrote:
>> You need to CC the maintainers. Please use ./script/get_maintainer.pl
>> to identify the right recipients and resend the patch.
>
>Thank you for kindly feedback! Sure will resend with correct CC :)

While you are sending next v, please re-phrase the patch desctiption
using imperative mood:

https://www.kernel.org/doc/html/v6.6/process/submitting-patches.html#describe-your-changes


>
>--
>
>Regards,
>Jones Syue | 薛懷宗
>QNAP Systems, Inc.
>

Re: [PATCH net-next] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner

[Jones Syue 薛懷宗]

> While you are sending next v, please re-phrase the patch desctiption
> using imperative mood:
> https://www.kernel.org/doc/html/v6.6/process/submitting-patches.html#describe-your-changes

Thank you for kindly feedback! Sure will do in next v :)

--

Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.