netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2
Date: Mon, 26 Feb 2024 14:39:06 +0000	[thread overview]
Message-ID: <ZdyiigYNGf8WVZNu@shell.armlinux.org.uk> (raw)
In-Reply-To: <TY3P286MB2611BD62C30B37A5BE02D3C5985A2@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>

On Mon, Feb 26, 2024 at 10:16:46PM +0800, Shengyu Qu wrote:
> Hi Russell,
> 
> > On Mon, Feb 26, 2024 at 09:23:46PM +0800, Shengyu Qu wrote:
> > > ODI DFP-34X-2C2 is capable of 2500base-X, but incorrectly report its
> > > capabilities in the EEPROM.
> > > So use sfp_quirk_2500basex for this module to allow 2500Base-X mode.
> > This was previously submitted by Sergio Palumbo, and comes in two
> > different forms - an OEM version and non-OEM. There was extensive
> > discussion about this, and the result is that I'm not accepting this
> > quirk for this module.
> > 
> > The reason is that the module _defaults_ to 1000base-X and requires
> > manual reconfiguration by the user to operate at 2500base-X.
> > Unfortunately, there is no way for the kernel to know whether that
> > reconfiguration has occurred.
> No, In the firmware of this stick, the speed rate is configured to auto
> negotiation rather than fixed 1000base-X.

How does this "auto negotiation" work?

I mean *exactly* how does it work? How does it know whether the host is
operating at 1000base-X or 2500base-X?

There is *no* inband protocol to allow this to be negotiated.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2024-02-26 14:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 13:23 [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2 Shengyu Qu
2024-02-26 14:04 ` Russell King (Oracle)
2024-02-26 14:16   ` Shengyu Qu
2024-02-26 14:39     ` Russell King (Oracle) [this message]
2024-02-26 14:51       ` Shengyu Qu
2024-02-26 15:06         ` Andrew Lunn
2024-02-26 15:20           ` Shengyu Qu
2024-02-26 15:50             ` Russell King (Oracle)
2024-02-26 15:42           ` Shengyu Qu
2024-02-26 15:52             ` Andrew Lunn
2024-02-26 15:42         ` Russell King (Oracle)
2024-02-26 15:51           ` Shengyu Qu
2024-02-28 10:42           ` Shengyu Qu
2024-02-28 11:15             ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdyiigYNGf8WVZNu@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=wiagn233@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).