From: Jiri Pirko <jiri@resnulli.us>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Jakub Kicinski <kuba@kernel.org>,
Michael Chan <michael.chan@broadcom.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, pavan.chebbi@broadcom.com,
andrew.gospodarek@broadcom.com, richardcochran@gmail.com
Subject: Re: [PATCH net-next 1/2] bnxt_en: Introduce devlink runtime driver param to set ptp tx timeout
Date: Fri, 1 Mar 2024 12:34:32 +0100 [thread overview]
Message-ID: <ZeG9SH_RlZZzNi5Z@nanopsycho> (raw)
In-Reply-To: <f1d31561-f5b5-486f-98e4-75ccc2723131@linux.dev>
Thu, Feb 29, 2024 at 10:22:19PM CET, vadim.fedorenko@linux.dev wrote:
>On 29/02/2024 17:30, Jakub Kicinski wrote:
>> On Thu, 29 Feb 2024 18:11:49 +0100 Jiri Pirko wrote:
>> > Idk. This does not look sane to me at all. Will we have custom knobs to
>> > change timeout for arbitrary FW commands as this as a common thing?
>> > Driver is the one to take care of timeouts of FW gracefully, he should
>> > know the FW, not the user. Therefore exposing user knobs like this
>> > sounds pure wrong to me.
>> >
>> > nack for adding this to devlink.
>>
>> +1
>>
>> BTW why is the documentation in a different patch that the param :(
>>
>> > If this is some maybe-to-be-common ptp thing, can that be done as part
>> > of ptp api perhaps?
>
>Jiri, do you mean extend current ioctl used to enable/disable HW
>timestamps?
Maybe.
next prev parent reply other threads:[~2024-03-01 11:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 7:02 [PATCH net-next 0/2] bnxt_en: Support configurable PTP TX timeout Michael Chan
2024-02-29 7:02 ` [PATCH net-next 1/2] bnxt_en: Introduce devlink runtime driver param to set ptp tx timeout Michael Chan
2024-02-29 9:27 ` Vadim Fedorenko
2024-02-29 17:11 ` Jiri Pirko
2024-02-29 17:30 ` Jakub Kicinski
2024-02-29 21:22 ` Vadim Fedorenko
2024-03-01 1:49 ` Jakub Kicinski
2024-03-01 7:39 ` Pavan Chebbi
2024-03-01 17:18 ` Jakub Kicinski
2024-03-07 3:50 ` Pavan Chebbi
2024-03-07 4:19 ` Jakub Kicinski
2024-03-01 11:34 ` Jiri Pirko [this message]
2024-02-29 7:02 ` [PATCH net-next 2/2] bnxt_en: Retry for TX timestamp from FW until timeout specified Michael Chan
2024-02-29 9:23 ` Vadim Fedorenko
2024-02-29 16:43 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeG9SH_RlZZzNi5Z@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).