Re: [PATCH net v2] netfilter: Add protection for bmp length out of range

Pablo Neira Ayuso
2024-03-04T12:41:26Z

On Sat, Mar 02, 2024 at 12:52:41PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > + if (f->sz > 32)
> > > + return H323_ERROR_RANGE;
> >
> > Could you possibly place this in get_bitmap()? IIRC these are the only
> > two calls to this function.
>
> How would you signal the error? I think this patch is fine as-is.

Provide the bitmap instead as parameter, but this opencode variant
also LGTM, I am probably overdoing, we can take this as is.

Thanks.