From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kadlec@netfilter.org" <kadlec@netfilter.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH net v2] netfilter: Add protection for bmp length out of range
Date: Mon, 4 Mar 2024 13:41:19 +0100 [thread overview]
Message-ID: <ZeXBb6dKL0GQe909@calendula> (raw)
In-Reply-To: <20240302115241.GA7494@breakpoint.cc>
On Sat, Mar 02, 2024 at 12:52:41PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > + if (f->sz > 32)
> > > + return H323_ERROR_RANGE;
> >
> > Could you possibly place this in get_bitmap()? IIRC these are the only
> > two calls to this function.
>
> How would you signal the error? I think this patch is fine as-is.
Provide the bitmap instead as parameter, but this opencode variant
also LGTM, I am probably overdoing, we can take this as is.
Thanks.
prev parent reply other threads:[~2024-03-04 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 15:12 [PATCH net v2] netfilter: Add protection for bmp length out of range Lena Wang (王娜)
2024-03-01 15:29 ` Jiri Pirko
2024-03-02 9:48 ` Pablo Neira Ayuso
2024-03-02 11:52 ` Florian Westphal
2024-03-04 12:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeXBb6dKL0GQe909@calendula \
--to=pablo@netfilter.org \
--cc=Lena.Wang@mediatek.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).