From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 547023B29A; Mon, 4 Mar 2024 14:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709562889; cv=none; b=KxYXOjRdLUBI/Ot2CMW2HRfTxateGNuiBX7tBoAaOlCtIlGxHFL+A1d+bA/phCHZwscpkeQ5TPYQ+hAyFUMsG03Tus/53JvSN+0Bbztz4s/HgRsgmPmv6VmJtslaQuwhc/hUpzlpOovdz2VpaEVmwlNi+U8SxQEE5WNjaMwNvSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709562889; c=relaxed/simple; bh=HMpF7T5iHKhsnzi5IxX4Ma4BVYrw0VHarv3ljpCi1bY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GxoefSB4z7BrjT4IW7xCKkDh466dPr0cWn2mNosz0kvI10Qduu+brCaTBtKgBUQcxJsDmManYeLF6LiD+ZrjtdpnMX99kQ8HM2GOjDqqMlIFbiFh/yrxw+rmai9KjufpZd5qGLZ3ljBD7GWzl3yi4Fdp8WhkWOw2CB5NV1c0EZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=ZiR2zah/; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ZiR2zah/" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=usEEQkzRwci7m0iHtPlNYF6Man+QvuNlFoidwTn2uUE=; b=ZiR2zah/Kcfjj/Rvo3fPm8zTTF 3bOPX75V9ivKRWvkLIwPZArI143ioWhQ2ybmvAhkfZpIL7BjOPNzohEIH/tXE0lWST2vEsLBw4eWK rlB1fDp/yXmglnMvlKrNW+tRxYY9ZDI37nIKMJSg3pEGtxY90auKdfm3ZTS6HJeIPXxbevg+pMaKn Z6KV3zQdEttEouPHQcvn6WpxhIhO2ZnjX3z15Qeyi2sLq5ThUSKrpjpuBX0idLQe5oAcMUUlVPyg3 oSBM4Ydy/xja4rprHo+fB4pE76WvJtGMlhDEXGcERODBtMfJRKVDY/z0nu/F3L4SKvLnV2Mn7IsGB GC0AvfbA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51706) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rh9Op-0005mX-1j; Mon, 04 Mar 2024 14:34:39 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rh9Oo-0004Z1-P6; Mon, 04 Mar 2024 14:34:38 +0000 Date: Mon, 4 Mar 2024 14:34:38 +0000 From: "Russell King (Oracle)" To: Romain Gantois Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Maxime Chevallier , Miquel Raynal , Thomas Petazzoni , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Clark Wang Subject: Re: [PATCH net-next v5 6/7] net: phy: qcom: at803x: Avoid hibernating if MAC requires RX clock Message-ID: References: <20240301-rxc_bugfix-v5-0-8dac30230050@bootlin.com> <20240301-rxc_bugfix-v5-6-8dac30230050@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240301-rxc_bugfix-v5-6-8dac30230050@bootlin.com> Sender: Russell King (Oracle) On Fri, Mar 01, 2024 at 04:35:03PM +0100, Romain Gantois wrote: > From: Russell King > > Stmmac controllers connected to an at803x PHY cannot resume properly after > suspend when WoL is enabled. This happens because the MAC requires an RX > clock generated by the PHY to initialize its hardware properly. But the RX > clock is cut when the PHY suspends and isn't brought up until the MAC > driver resumes the phylink. > > Prevent the at803x PHY driver from going into suspend if the attached MAC > driver always requires an RX clock signal. > > Reported-by: Clark Wang > Link: https://lore.kernel.org/all/20230202081559.3553637-1-xiaoning.wang@nxp.com/ > Signed-off-by: Russell King Wrong wrong wrong wrong wrong. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!