* [PATCH] ip.7: Add not supported by SOCK_STREAM to socket options
@ 2024-03-02 18:19 Oliver Crumrine
2024-03-04 16:15 ` Alejandro Colomar
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Crumrine @ 2024-03-02 18:19 UTC (permalink / raw)
To: alx; +Cc: linux-kernel, linux-man, netdev
It was not made clear in several socket options that they were not
supported by SOCK_STREAM; this patch fixes that.
Socket options not supported by SOCK_STREAM are handled in the
ip_cmsg_recv_offset function in net/ipv4/ip_sockglue.c. The function is
called for udp sockets, and indirectly by ping and raw sockets, but not
for TCP sockets, as they don't support these options.
Signed-off-by: Oliver Crumrine <ozlinuxc@gmail.com>
---
man7/ip.7 | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/man7/ip.7 b/man7/ip.7
index 2b4b06324..104e65feb 100644
--- a/man7/ip.7
+++ b/man7/ip.7
@@ -828,6 +828,9 @@ is not zero, the primary local address of the interface specified by the
index overwrites
.I ipi_spec_dst
for the routing table lookup.
+Not supported for
+.B SOCK_STREAM
+sockets.
.TP
.BR IP_RECVERR " (since Linux 2.2)"
.\" Precisely: since Linux 2.1.15
@@ -989,6 +992,9 @@ in which the kernel returns the original destination address
of the datagram being received.
The ancillary message contains a
.IR "struct sockaddr_in" .
+Not supported for
+.B SOCK_STREAM
+sockets.
.TP
.BR IP_RECVTOS " (since Linux 2.2)"
.\" Precisely: since Linux 2.1.68
@@ -998,6 +1004,9 @@ ancillary message is passed with incoming packets.
It contains a byte which specifies the Type of Service/Precedence
field of the packet header.
Expects a boolean integer flag.
+Not supported for
+.B SOCK_STREAM
+sockets.
.TP
.BR IP_RECVTTL " (since Linux 2.2)"
.\" Precisely: since Linux 2.1.68
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ip.7: Add not supported by SOCK_STREAM to socket options
2024-03-02 18:19 [PATCH] ip.7: Add not supported by SOCK_STREAM to socket options Oliver Crumrine
@ 2024-03-04 16:15 ` Alejandro Colomar
0 siblings, 0 replies; 2+ messages in thread
From: Alejandro Colomar @ 2024-03-04 16:15 UTC (permalink / raw)
To: Oliver Crumrine; +Cc: linux-kernel, linux-man, netdev
[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]
Hi Oliver,
On Sat, Mar 02, 2024 at 01:19:42PM -0500, Oliver Crumrine wrote:
> It was not made clear in several socket options that they were not
> supported by SOCK_STREAM; this patch fixes that.
>
> Socket options not supported by SOCK_STREAM are handled in the
> ip_cmsg_recv_offset function in net/ipv4/ip_sockglue.c. The function is
> called for udp sockets, and indirectly by ping and raw sockets, but not
> for TCP sockets, as they don't support these options.
>
> Signed-off-by: Oliver Crumrine <ozlinuxc@gmail.com>
Could you write some small example programs demonstrating that these are
not supported? I'd like to check it with a small program, if possible.
Have a lovely say!
Alex
> ---
> man7/ip.7 | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/man7/ip.7 b/man7/ip.7
> index 2b4b06324..104e65feb 100644
> --- a/man7/ip.7
> +++ b/man7/ip.7
> @@ -828,6 +828,9 @@ is not zero, the primary local address of the interface specified by the
> index overwrites
> .I ipi_spec_dst
> for the routing table lookup.
> +Not supported for
> +.B SOCK_STREAM
> +sockets.
> .TP
> .BR IP_RECVERR " (since Linux 2.2)"
> .\" Precisely: since Linux 2.1.15
> @@ -989,6 +992,9 @@ in which the kernel returns the original destination address
> of the datagram being received.
> The ancillary message contains a
> .IR "struct sockaddr_in" .
> +Not supported for
> +.B SOCK_STREAM
> +sockets.
> .TP
> .BR IP_RECVTOS " (since Linux 2.2)"
> .\" Precisely: since Linux 2.1.68
> @@ -998,6 +1004,9 @@ ancillary message is passed with incoming packets.
> It contains a byte which specifies the Type of Service/Precedence
> field of the packet header.
> Expects a boolean integer flag.
> +Not supported for
> +.B SOCK_STREAM
> +sockets.
> .TP
> .BR IP_RECVTTL " (since Linux 2.2)"
> .\" Precisely: since Linux 2.1.68
> --
> 2.44.0
>
--
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-04 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-02 18:19 [PATCH] ip.7: Add not supported by SOCK_STREAM to socket options Oliver Crumrine
2024-03-04 16:15 ` Alejandro Colomar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).