From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Robert Marko <robimarko@gmail.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, andrew@lunn.ch,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, ansuelsmth@gmail.com,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net] net: phy: qca807x: fix compilation when CONFIG_GPIOLIB is not set
Date: Mon, 4 Mar 2024 19:27:18 +0000 [thread overview]
Message-ID: <ZeYglnW6/k0nvmiL@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240304192244.2924407-1-robimarko@gmail.com>
On Mon, Mar 04, 2024 at 08:21:36PM +0100, Robert Marko wrote:
> - if (IS_ENABLED(CONFIG_GPIOLIB)) {
> +#if IS_ENABLED(CONFIG_GPIOLIB)
> /* Make sure we don't have mixed leds node and gpio-controller
> * to prevent registering leds and having gpio-controller usage
> * conflicting with them.
> @@ -749,7 +749,7 @@ static int qca807x_probe(struct phy_device *phydev)
> if (ret)
> return ret;
> }
> - }
> +#endif
I know it makes for a bigger patch, but #if is not equivalent to if()
in terms of indentation, so the indentation also needs to be changed.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-03-04 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 19:21 [PATCH net] net: phy: qca807x: fix compilation when CONFIG_GPIOLIB is not set Robert Marko
2024-03-04 19:27 ` Russell King (Oracle) [this message]
2024-03-04 19:29 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeYglnW6/k0nvmiL@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox