From: Breno Leitao <leitao@debian.org>
To: hyper <hyperlyzcs@gmail.com>
Cc: shannon.nelson@amd.com, brett.creeley@amd.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jitxie@tencent.com,
huntazhang@tencent.com
Subject: Re: [PATCH net V2] net: pds_core: Fix possible double free in error handling path
Date: Mon, 4 Mar 2024 12:26:32 -0800 [thread overview]
Message-ID: <ZeYueIRasQTY1TzX@gmail.com> (raw)
In-Reply-To: <20240303084954.14498-1-hyperlyzcs@gmail.com>
On Sun, Mar 03, 2024 at 04:49:54PM +0800, hyper wrote:
> When auxiliary_device_add() returns error and then calls
> auxiliary_device_uninit(), Callback function pdsc_auxbus_dev_release
> calls kfree(padev) to free memory. We shouldn't call kfree(padev)
> again in the error handling path.
>
> Fix this by cleaning up the redundant kfree() and putting
> the error handling back to where the errors happened.
>
> Fixes: 4569cce43bc6 ("pds_core: add auxiliary_bus devices")
> Signed-off-by: hyper <hyperlyzcs@gmail.com>
I liked this v2 better.
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2024-03-04 20:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 2:23 [PATCH] pds_core: Fix possible double free in error handling path hyper
2024-03-01 17:55 ` Nelson, Shannon
2024-03-03 8:49 ` [PATCH net V2] net: " hyper
2024-03-04 17:21 ` Nelson, Shannon
2024-03-04 20:26 ` Breno Leitao [this message]
2024-03-05 14:58 ` Paolo Abeni
2024-03-06 10:57 ` [PATCH net V3] " Yongzhi Liu
2024-03-06 13:44 ` Wojciech Drewek
2024-03-06 17:05 ` Nelson, Shannon
2024-03-07 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeYueIRasQTY1TzX@gmail.com \
--to=leitao@debian.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=huntazhang@tencent.com \
--cc=hyperlyzcs@gmail.com \
--cc=jitxie@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).