From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Breno Leitao <leitao@debian.org>
Cc: Harald Welte <laforge@gnumonks.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
horms@kernel.org, dsahern@kernel.org,
"open list:GTP (GPRS Tunneling Protocol)"
<osmocom-net-gprs@lists.osmocom.org>
Subject: Re: [PATCH net-next 2/3] net: gtp: Remove generic .ndo_get_stats64
Date: Tue, 5 Mar 2024 16:39:02 +0100 [thread overview]
Message-ID: <Zec8ln0UnRO9UNrm@calendula> (raw)
In-Reply-To: <20240305121524.2254533-2-leitao@debian.org>
On Tue, Mar 05, 2024 at 04:15:22AM -0800, Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
>
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
next prev parent reply other threads:[~2024-03-05 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 12:15 [PATCH net-next 1/3] net: gtp: Leverage core stats allocator Breno Leitao
2024-03-05 12:15 ` [PATCH net-next 2/3] net: gtp: Remove generic .ndo_get_stats64 Breno Leitao
2024-03-05 15:39 ` Pablo Neira Ayuso [this message]
2024-03-05 12:15 ` [PATCH net-next 3/3] net: gtp: Move net_device assigned in setup Breno Leitao
2024-03-05 15:39 ` Pablo Neira Ayuso
2024-03-05 15:38 ` [PATCH net-next 1/3] net: gtp: Leverage core stats allocator Pablo Neira Ayuso
2024-03-07 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zec8ln0UnRO9UNrm@calendula \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=laforge@gnumonks.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).