[patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jiri Pirko]

From: Jiri Pirko <jiri@nvidia.com>

The enum is defined, however the pin capabilities attribute does
refer to it. Add this missing enum field.

This fixes ynl cli output:

Example current output:
$ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
{'capabilities': 4,
 ...
Example new output:
$ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
{'capabilities': {'state-can-change'},
 ...

Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
 Documentation/netlink/specs/dpll.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml
index 8dc1df5cfae7..95b0eb1486bf 100644
--- a/Documentation/netlink/specs/dpll.yaml
+++ b/Documentation/netlink/specs/dpll.yaml
@@ -312,6 +312,7 @@ attribute-sets:
       -
         name: capabilities
         type: u32
+        enum: pin-capabilities
       -
         name: parent-device
         type: nest
-- 
2.43.2

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jiri Pirko]

Wed, Mar 06, 2024 at 01:07:39PM CET, jiri@resnulli.us wrote:
>From: Jiri Pirko <jiri@nvidia.com>
>
>The enum is defined, however the pin capabilities attribute does
>refer to it. Add this missing enum field.
>
>This fixes ynl cli output:
>
>Example current output:
>$ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
>{'capabilities': 4,
> ...
>Example new output:
>$ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
>{'capabilities': {'state-can-change'},
> ...
>
>Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
>Signed-off-by: Jiri Pirko <jiri@nvidia.com>

Note that netdev/cc_maintainers fails as I didn't cc michal.michalik@intel.com
on purpose, as the address bounces.

Btw, do we have a way to ignore such ccs? .get_maintainer.ignore looks
like a good candidate, but is it okay to put closed emails there?

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jakub Kicinski]

On Wed, 6 Mar 2024 16:25:34 +0100 Jiri Pirko wrote:
> >Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> >Signed-off-by: Jiri Pirko <jiri@nvidia.com>  
> 
> Note that netdev/cc_maintainers fails as I didn't cc michal.michalik@intel.com
> on purpose, as the address bounces.
> 
> Btw, do we have a way to ignore such ccs? .get_maintainer.ignore looks
> like a good candidate, but is it okay to put closed emails there?

Oh, great, I wasn't aware of this.

I think I have his private email, let me follow up off list and either
put his @intel.com address in the mailmap or the ignore list.

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jakub Kicinski]

On Wed, 6 Mar 2024 07:34:19 -0800 Jakub Kicinski wrote:
> > Note that netdev/cc_maintainers fails as I didn't cc michal.michalik@intel.com
> > on purpose, as the address bounces.
> > 
> > Btw, do we have a way to ignore such ccs? .get_maintainer.ignore looks
> > like a good candidate, but is it okay to put closed emails there?  
> 
> Oh, great, I wasn't aware of this.
> 
> I think I have his private email, let me follow up off list and either
> put his @intel.com address in the mailmap or the ignore list.

Hi Jiri! Do you still want to add him to the ignore list?

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jiri Pirko]

Wed, Mar 13, 2024 at 03:26:08PM CET, kuba@kernel.org wrote:
>On Wed, 6 Mar 2024 07:34:19 -0800 Jakub Kicinski wrote:
>> > Note that netdev/cc_maintainers fails as I didn't cc michal.michalik@intel.com
>> > on purpose, as the address bounces.
>> > 
>> > Btw, do we have a way to ignore such ccs? .get_maintainer.ignore looks
>> > like a good candidate, but is it okay to put closed emails there?  
>> 
>> Oh, great, I wasn't aware of this.
>> 
>> I think I have his private email, let me follow up off list and either
>> put his @intel.com address in the mailmap or the ignore list.
>
>Hi Jiri! Do you still want to add him to the ignore list?

If we are going to start to use .get_maintainer.ignore for this purpose,
yes please. Should I send the patch? net-next is closed anyway...

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jakub Kicinski]

On Wed, 13 Mar 2024 15:58:19 +0100 Jiri Pirko wrote:
> >> I think I have his private email, let me follow up off list and either
> >> put his @intel.com address in the mailmap or the ignore list.  
> >
> >Hi Jiri! Do you still want to add him to the ignore list?  
> 
> If we are going to start to use .get_maintainer.ignore for this purpose,
> yes please. Should I send the patch? net-next is closed anyway...

With the current tooling I think it's the best we can do.
If someone disagrees let them shout at us.
And we'll shout back that LF should take care of creating
appropriate tooling.
But shouting seems unlikely, I sent a patch to add Jeff K 
and nobody batted an eyelid so far.

Send it for net, it's like a MAINTAINERS update.

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jiri Pirko]

Wed, Mar 13, 2024 at 04:31:11PM CET, kuba@kernel.org wrote:
>On Wed, 13 Mar 2024 15:58:19 +0100 Jiri Pirko wrote:
>> >> I think I have his private email, let me follow up off list and either
>> >> put his @intel.com address in the mailmap or the ignore list.  
>> >
>> >Hi Jiri! Do you still want to add him to the ignore list?  
>> 
>> If we are going to start to use .get_maintainer.ignore for this purpose,
>> yes please. Should I send the patch? net-next is closed anyway...
>
>With the current tooling I think it's the best we can do.
>If someone disagrees let them shout at us.
>And we'll shout back that LF should take care of creating
>appropriate tooling.
>But shouting seems unlikely, I sent a patch to add Jeff K 
>and nobody batted an eyelid so far.
>
>Send it for net, it's like a MAINTAINERS update.

Interesting, his email gets no longer returned by get_maintainers.
perhaps there is some timeout there (I was looking but got a bit
Perlsick :)

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[Jakub Kicinski]

On Wed,  6 Mar 2024 13:07:39 +0100 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> The enum is defined, however the pin capabilities attribute does
> refer to it. Add this missing enum field.
> 
> This fixes ynl cli output:
> 
> Example current output:
> $ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
> {'capabilities': 4,
>  ...
> Example new output:
> $ sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml --do pin-get --json '{"id": 0}'
> {'capabilities': {'state-can-change'},
>  ...
> 
> Fixes: 3badff3a25d8 ("dpll: spec: Add Netlink spec in YAML")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Re: [patch net-next] dpll: spec: use proper enum for pin capabilities attribute

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  6 Mar 2024 13:07:39 +0100 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
> 
> The enum is defined, however the pin capabilities attribute does
> refer to it. Add this missing enum field.
> 
> This fixes ynl cli output:
> 
> [...]

Here is the summary with links:
  - [net-next] dpll: spec: use proper enum for pin capabilities attribute
    https://git.kernel.org/netdev/net-next/c/5c497a64820e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html