public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: David Gouarin <dgouarin@gmail.com>
Cc: <camelia.groza@nxp.com>, <netdev@vger.kernel.org>,
	<madalin.bucur@oss.nxp.com>, <david.gouarin@thalesgroup.com>
Subject: Re: [PATCH 1/1] [PATCH net] dpaa_eth: fix XDP queue index
Date: Wed, 6 Mar 2024 16:37:41 +0100	[thread overview]
Message-ID: <ZeiNxaq3jzloO9l6@boxer> (raw)
In-Reply-To: <20240306143408.216299-1-dgouarin@gmail.com>

On Wed, Mar 06, 2024 at 03:34:08PM +0100, David Gouarin wrote:
> Make it possible to bind a XDP socket to a queue id.
> The DPAA FQ Id was passed to the XDP program in the XDP packet metadata
> which made it unusable with bpf_map_redirect.
> Instead of the DPAA FQ Id, initialise the XDP rx queue with the channel id.
> 

Fixes: tag, please.

Also you have doubled [PATCH] [PATCH...] in your subject.

> Signed-off-by: David Gouarin <dgouarin@gmail.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index dcbc598b11c6..988dc9237368 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -1154,7 +1154,7 @@ static int dpaa_fq_init(struct dpaa_fq *dpaa_fq, bool td_enable)
>  	if (dpaa_fq->fq_type == FQ_TYPE_RX_DEFAULT ||
>  	    dpaa_fq->fq_type == FQ_TYPE_RX_PCD) {
>  		err = xdp_rxq_info_reg(&dpaa_fq->xdp_rxq, dpaa_fq->net_dev,
> -				       dpaa_fq->fqid, 0);
> +				       dpaa_fq->channel, 0);
>  		if (err) {
>  			dev_err(dev, "xdp_rxq_info_reg() = %d\n", err);
>  			return err;
> -- 
> 2.34.1
> 
> 

  reply	other threads:[~2024-03-06 15:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 14:34 [PATCH 1/1] [PATCH net] dpaa_eth: fix XDP queue index David Gouarin
2024-03-06 15:37 ` Maciej Fijalkowski [this message]
2024-03-07 14:24   ` [PATCH net v2] " David Gouarin
2024-03-07 15:51     ` Maciej Fijalkowski
2024-03-07 17:48       ` david gouarin
2024-03-20 11:25       ` [PATCH net v3] " David Gouarin
2024-03-21 12:26         ` Paolo Abeni
2024-04-09  9:30           ` [PATCH net v4] " David Gouarin
2024-04-11  2:40             ` Jakub Kicinski
2024-04-11 11:34               ` Vladimir Oltean
2024-04-18  1:17                 ` Jakub Kicinski
2024-04-18  7:51                   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZeiNxaq3jzloO9l6@boxer \
    --to=maciej.fijalkowski@intel.com \
    --cc=camelia.groza@nxp.com \
    --cc=david.gouarin@thalesgroup.com \
    --cc=dgouarin@gmail.com \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox