[PATCH] dpll: indent DPLL option type by a tab

[PATCH] dpll: indent DPLL option type by a tab

[Prasad Pandit]

From: Prasad Pandit <pjp@fedoraproject.org>

Indent config option type by a tab. It helps Kconfig parsers
to read file without error.

Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
---
 drivers/dpll/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dpll/Kconfig b/drivers/dpll/Kconfig
index a4cae73f20d3..20607ed54243 100644
--- a/drivers/dpll/Kconfig
+++ b/drivers/dpll/Kconfig
@@ -4,4 +4,4 @@
 #
 
 config DPLL
-  bool
+	bool
-- 
2.44.0

Re: [PATCH] dpll: indent DPLL option type by a tab

[Jiri Pirko]

Fri, Mar 22, 2024 at 11:56:49AM CET, ppandit@redhat.com wrote:
>From: Prasad Pandit <pjp@fedoraproject.org>
>
>Indent config option type by a tab. It helps Kconfig parsers
>to read file without error.

You should indicate the target tree:

https://www.kernel.org/doc/html/next/process/maintainer-netdev.html?highlight=network#tl-dr

Also, please include "Fixes" tag.

net-next is closed, repost next week

pw-bot: defer

>
>Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
>---
> drivers/dpll/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/dpll/Kconfig b/drivers/dpll/Kconfig
>index a4cae73f20d3..20607ed54243 100644
>--- a/drivers/dpll/Kconfig
>+++ b/drivers/dpll/Kconfig
>@@ -4,4 +4,4 @@
> #
> 
> config DPLL
>-  bool
>+	bool
>-- 
>2.44.0
>

Re: [PATCH] dpll: indent DPLL option type by a tab

[Prasad Pandit]

Hi,

Thank you for a quick response.

On Fri, 22 Mar 2024 at 16:41, Jiri Pirko <jiri@resnulli.us> wrote:
> You should indicate the target tree:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html?highlight=network#tl-dr

* It is for the -net tree IIUC, not net-next.

> Also, please include "Fixes" tag.

* Last time they said not to include "Fixes" tag ->
https://lists.infradead.org/pipermail/linux-arm-kernel/2024-March/911714.html

Will send a revised patch. Thank you.
---
  - Prasad

Re: [PATCH] dpll: indent DPLL option type by a tab

[Jiri Pirko]

Fri, Mar 22, 2024 at 12:35:21PM CET, ppandit@redhat.com wrote:
>Hi,
>
>Thank you for a quick response.
>
>On Fri, 22 Mar 2024 at 16:41, Jiri Pirko <jiri@resnulli.us> wrote:
>> You should indicate the target tree:
>> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html?highlight=network#tl-dr
>
>* It is for the -net tree IIUC, not net-next.

Okay.


>
>> Also, please include "Fixes" tag.
>
>* Last time they said not to include "Fixes" tag ->
>https://lists.infradead.org/pipermail/linux-arm-kernel/2024-March/911714.html

AFAIU and IIRC, discussed couple of times, the outcome is that Fixes
should be included for netdev patches every time, no matter what is the
matter of the actual fix and target tree. Please include it. For -net it
is actually required.


>
>Will send a revised patch. Thank you.

You should have waited 24 hours. Did you read:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html?highlight=network#tl-dr
?

>---
>  - Prasad
>

Re: [PATCH] dpll: indent DPLL option type by a tab

[Prasad Pandit]

On Fri, 22 Mar 2024 at 17:44, Jiri Pirko <jiri@resnulli.us> wrote:
> >* Last time they said not to include "Fixes" tag ->
> >https://lists.infradead.org/pipermail/linux-arm-kernel/2024-March/911714.html
>
> AFAIU and IIRC, discussed couple of times, the outcome is that Fixes
> should be included for netdev patches every time, no matter what is the
> matter of the actual fix and target tree. Please include it. For -net it
> is actually required.

* Okay.

> You should have waited 24 hours. Did you read:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html?highlight=network#tl-dr

* Yes, I'm reading it. I'll remember it. Sorry for this time.

Thank you for a quick review. I appreciate it.
---
  - Prasad

Re: [PATCH] dpll: indent DPLL option type by a tab

[Dan Carpenter]

On Fri, Mar 22, 2024 at 01:13:59PM +0100, Jiri Pirko wrote:
> Fri, Mar 22, 2024 at 12:35:21PM CET, ppandit@redhat.com wrote:
> >Hi,
> >
> >Thank you for a quick response.
> >
> >On Fri, 22 Mar 2024 at 16:41, Jiri Pirko <jiri@resnulli.us> wrote:
> >> You should indicate the target tree:
> >> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html?highlight=network#tl-dr
> >
> >* It is for the -net tree IIUC, not net-next.
> 
> Okay.
> 
> 
> >
> >> Also, please include "Fixes" tag.
> >
> >* Last time they said not to include "Fixes" tag ->
> >https://lists.infradead.org/pipermail/linux-arm-kernel/2024-March/911714.html
> 
> AFAIU and IIRC, discussed couple of times, the outcome is that Fixes
> should be included for netdev patches every time, no matter what is the
> matter of the actual fix and target tree. Please include it. For -net it
> is actually required.
> 

I think there is some confusion here.  When Prasad Pandit says it
affects "Kconfig parsers", he is talking about his out-of-tree program.
https://github.com/pjps/config-kernel  It doesn't affect anything
in-tree so we wouldn't normally give it a Fixes tag.

There is a gray area around silencing static checker warnings.  Most of
the time, people say to not include a fixes tag for that.  But sometimes
people go the other way.  In this case, it's not really a static checker
warning, it's just a white space issue.  Also Prasad should just modify
config-kernel to match the in-kernel parser.

It's true that for Fixes it doesn't matter the tree, it only matters if
it's a bugfix.  People sometimes used to say "I'm not including a Fixes
tag because this is too new for -stable kernels".  But actually having
a Fixes tag that points to a very recent bug helps the stable
maintainers automatically mark it as NOT necessary.  (The stable
maintainers do sometimes backport patches which were not explicitly
marked with a Fixes tag because people forget to tag things sometimes).

regards,
dan carpenter