From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 183A53E49C for ; Fri, 22 Mar 2024 11:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711105796; cv=none; b=Y8XuCeJgufu4EshXLMYXiBgYBFHZLAET1EdnJ/6PIt6tY8TAM4POLInR3T9ubpN0VY6Hxsjud2shkHQlP31Q4qwPnFnIZhFnmdnxuRrZ/27Yq9caDf3Lq1v/Vj/WNCvghwqMQu3yeh/QqUCPEOlq2uK5fiN4ASuYS0Ql9PoUCmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711105796; c=relaxed/simple; bh=OhkkM88lwuLzNAXGaw51HYg1u1XUt5s+jikR7+zDo5k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nmXUCbepXxprRTPwKS3E6EfWCfo5yUiVLc6w/GktYXMi/cKiq1sc4Qa/VWYIVpwcjIm0G+unwykDSbSDNq4j1T4FKTBN3wjhSaVTSgrOgm1Q1VuLAAP8O66vjQUfzEn8CELC3vSXW2+iAiqPE64tyIbFma4m2B/KdPeIxOwcGV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=dLNx6cbs; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="dLNx6cbs" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4146fe16a1aso15370485e9.1 for ; Fri, 22 Mar 2024 04:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1711105792; x=1711710592; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OhkkM88lwuLzNAXGaw51HYg1u1XUt5s+jikR7+zDo5k=; b=dLNx6cbsXLVequzp7kB0WWhNgnYxRk5VQDrXKHR2i6VT8gaQZ1oaoZFiWzGGG3W7iy xI4RyYT8oOqjXH6nZrFEDgM5yAN4muxSsH8nFLlJ4ONbQKGF+srpyhhW7fWog6cNeK50 8mlxRGdItpDY1OzWeaIYVS+e45Y0xQ0DpCQd+V20zp9/2P74j5KQZooenXYOQFX4bbNj ahF6YI4YrXrcIavPzsxm60xdt0TTCjur49PiKNJ7c7fA42HoFj8IxQ+PxBk7gUzELS3x 7C88gH9ifv+RNsgJa40p90tlGvR5aiIc/XBmsHv8sv0rX88RzeXSD3nrPy4xuLt7ymFb y+Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711105792; x=1711710592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OhkkM88lwuLzNAXGaw51HYg1u1XUt5s+jikR7+zDo5k=; b=NnGVONXg2vGBs3POcR+iJg5ery1mGF+cmJVz5Y0VJz/5xBo5FK3e70iy/WAHNgVgzH dAE0BSH+1yLna7AmrMWWmxtgvN3zJDof/3dUluBHOmuU4aj65KETPVKxR+I7UTVMahsj L0u3L6ntBcHPNoZYBsv/JjfBl/OILnNzTOgrbtssHa66wQW/vIpB6Vs2nPaA+E3Pgvz4 fnlJWoZtgg0dpdv3OMhp76xAdumWGTLVREEWz8ki6pXzx7g69d1AuFivzqOUgo8uM4ML o+3tEvSIp8si5/JqSiHmKWS8TRfkdRjPYGz36Mtyh75onoKxuu+nv24bCh59GeW6Cv8D IV8A== X-Forwarded-Encrypted: i=1; AJvYcCXkuopFG9FyBAxmA9/Vt4kqNZaitXaA8S92X76yCJVwXvtngNUoOSu95sstjeXtOV+KMwHd9HqRPS+hLL6fmyVGKsZ9o806 X-Gm-Message-State: AOJu0Ywe7g9a4HHpXxQq091rrNmOjabzvQuRoSDfDuav3/NSpFlMLcE5 x1KwNwYYU9P4l3+KmFr/GUnMkPT2kW5ag7SkxSkR5QBtjbgMw+SjqQKaRWpirRg= X-Google-Smtp-Source: AGHT+IEGh31F6bP7iW8kYZ27cyXYp8lSwvwrvkTsxWHY4EN8KOt+AluViZO2itKlEWQETskirhb/TA== X-Received: by 2002:a05:600c:3ca6:b0:413:f75f:98b6 with SMTP id bg38-20020a05600c3ca600b00413f75f98b6mr1385875wmb.26.1711105792061; Fri, 22 Mar 2024 04:09:52 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id z14-20020a05600c0a0e00b004147d1bd57csm1016431wmp.8.2024.03.22.04.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 04:09:51 -0700 (PDT) Date: Fri, 22 Mar 2024 12:09:48 +0100 From: Jiri Pirko To: Ravi Gunasekaran Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, srk@ti.com Subject: Re: [PATCH net] net: hsr: hsr_slave: Fix the promiscuous mode in offload mode Message-ID: References: <20240322100447.27615-1-r-gunasekaran@ti.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240322100447.27615-1-r-gunasekaran@ti.com> Fri, Mar 22, 2024 at 11:04:47AM CET, r-gunasekaran@ti.com wrote: >commit e748d0fd66ab ("net: hsr: Disable promiscuous mode in >offload mode") disables promiscuous mode of slave devices >while creating an HSR interface. But while deleting the >HSR interface, it does not take care of it. It decreases the >promiscuous mode count, which eventually enables promiscuous >mode on the slave devices when creating HSR interface again. > >Fix this by not decrementing the promiscuous mode count while >deleting the HSR interface when offload is enabled. > >Fixes: e748d0fd66ab ("net: hsr: Disable promiscuous mode in offload mode") >Signed-off-by: Ravi Gunasekaran Reviewed-by: Jiri Pirko